Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose mailbox_for method #36181

Merged
merged 4 commits into from May 10, 2019
Merged

Conversation

@jamesdabbs
Copy link
Contributor

@jamesdabbs jamesdabbs commented May 4, 2019

Currently, the only exposed entry point into the ApplicationMailbox's configured
routing system is to call route, which performs a lot of work to fully
process inbound email. It'd be nice to have a way (e.g. in test) of checking
which mailbox an email would route to without necessarily processing it yet.

For what it's worth, I think it'd be helpful to add more inline documentation and indicate which methods are and aren't intended to be public and supported. I'd be happy to add those - either in this PR or in a separate one - if y'all think that would be valuable.

Currently, the only exposed entry point into the ApplicationMailbox's configured
routing system is to call `route`, which performs a lot of work to fully
`process` inbound email. It'd be nice to have a way (e.g. in test) of checking
which mailbox an email would route to without necessarily processing it yet.
actionmailbox/lib/action_mailbox/routing.rb Outdated Show resolved Hide resolved
actionmailbox/test/unit/mailbox/routing_test.rb Outdated Show resolved Hide resolved
@georgeclaghorn
Copy link
Contributor

@georgeclaghorn georgeclaghorn commented May 6, 2019

This needs a changelog entry. Can you please add one?

@jamesdabbs
Copy link
Contributor Author

@jamesdabbs jamesdabbs commented May 9, 2019

Gladly! Let me know if you'd like to see any other changes.

@georgeclaghorn georgeclaghorn merged commit 6394f9d into rails:master May 10, 2019
1 of 2 checks passed
benoittgt added a commit to rspec/rspec-rails that referenced this issue Nov 1, 2020
benoittgt added a commit to rspec/rspec-rails that referenced this issue Nov 2, 2020
benoittgt added a commit to rspec/rspec-rails that referenced this issue Nov 3, 2020
benoittgt added a commit to rspec/rspec-rails that referenced this issue Nov 3, 2020
benoittgt added a commit to rspec/rspec-rails that referenced this issue Nov 8, 2020
benoittgt added a commit to rspec/rspec-rails that referenced this issue Nov 23, 2020
benoittgt added a commit to rspec/rspec-rails that referenced this issue Dec 2, 2020
JonRowe added a commit to rspec/rspec-rails that referenced this issue Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants