Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose `mailbox_for` method #36181

Merged
merged 4 commits into from May 10, 2019

Conversation

Projects
None yet
2 participants
@jamesdabbs
Copy link
Contributor

commented May 4, 2019

Currently, the only exposed entry point into the ApplicationMailbox's configured
routing system is to call route, which performs a lot of work to fully
process inbound email. It'd be nice to have a way (e.g. in test) of checking
which mailbox an email would route to without necessarily processing it yet.

For what it's worth, I think it'd be helpful to add more inline documentation and indicate which methods are and aren't intended to be public and supported. I'd be happy to add those - either in this PR or in a separate one - if y'all think that would be valuable.

Expose `mailbox_for` method
Currently, the only exposed entry point into the ApplicationMailbox's configured
routing system is to call `route`, which performs a lot of work to fully
`process` inbound email. It'd be nice to have a way (e.g. in test) of checking
which mailbox an email would route to without necessarily processing it yet.
Show resolved Hide resolved actionmailbox/lib/action_mailbox/routing.rb Outdated
Show resolved Hide resolved actionmailbox/test/unit/mailbox/routing_test.rb Outdated

jamesdabbs added some commits May 5, 2019

Rename variable to represent type
per comments from CR
@georgeclaghorn

This comment has been minimized.

Copy link
Member

commented May 6, 2019

This needs a changelog entry. Can you please add one?

@jamesdabbs

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

Gladly! Let me know if you'd like to see any other changes.

@georgeclaghorn georgeclaghorn merged commit 6394f9d into rails:master May 10, 2019

1 of 2 checks passed

buildkite/rails Build #61055 failed (22 minutes, 18 seconds)
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.