Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing file to require digest/uuid on active_support core ext #36470

Merged

Conversation

@lucasprag
Copy link
Contributor

lucasprag commented Jun 12, 2019

Summary

I noticed I had to require "active_support/core_ext/digest/uuid" to be able to use Digest::UUID so I dig into active support and I found that all the core extensions have a file to include their respective files, but digest so I added it.

Other Information

I think the expected behaviour is to have Digest::UUID available for use so I don't think I should change changelogs or docs.

Thanks

@rails-bot rails-bot bot added the activesupport label Jun 12, 2019
@lucasprag

This comment has been minimized.

Copy link
Contributor Author

lucasprag commented Jun 12, 2019

To be more clear about my fix, before:
Screen Shot 2019-06-12 at 4 50 19 PM

after:
Screen Shot 2019-06-12 at 4 51 38 PM

@rafaelfranca rafaelfranca merged commit 0ad238f into rails:master Jun 12, 2019
2 checks passed
2 checks passed
buildkite/rails Build #61678 passed (9 minutes, 1 second)
Details
codeclimate All good!
Details
rafaelfranca added a commit that referenced this pull request Jun 12, 2019
…e-digest

Add missing file to require digest/uuid on active_support core ext
rafaelfranca added a commit that referenced this pull request Jun 12, 2019
…e-digest

Add missing file to require digest/uuid on active_support core ext
suketa added a commit to suketa/rails_sandbox that referenced this pull request Oct 21, 2019
Add missing file to require digest/uuid on active_support core ext
rails/rails#36470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.