Add missing file to require digest/uuid on active_support core ext #36470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be more clear about my fix, before: after: |
rafaelfranca
added a commit
that referenced
this pull request
Jun 12, 2019
…e-digest Add missing file to require digest/uuid on active_support core ext
rafaelfranca
added a commit
that referenced
this pull request
Jun 12, 2019
…e-digest Add missing file to require digest/uuid on active_support core ext
suketa
added a commit
to suketa/rails_sandbox
that referenced
this pull request
Oct 21, 2019
Add missing file to require digest/uuid on active_support core ext rails/rails#36470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed I had to
require "active_support/core_ext/digest/uuid"to be able to useDigest::UUIDso I dig into active support and I found that all the core extensions have a file to include their respective files, butdigestso I added it.Other Information
I think the expected behaviour is to have
Digest::UUIDavailable for use so I don't think I should change changelogs or docs.Thanks