Skip to content

Add missing file to require digest/uuid on active_support core ext#36470

Merged
rafaelfranca merged 1 commit into
rails:masterfrom
lucasprag:activesupport/missing-require-digest
Jun 12, 2019
Merged

Add missing file to require digest/uuid on active_support core ext#36470
rafaelfranca merged 1 commit into
rails:masterfrom
lucasprag:activesupport/missing-require-digest

Conversation

@lucasprag
Copy link
Copy Markdown
Contributor

Summary

I noticed I had to require "active_support/core_ext/digest/uuid" to be able to use Digest::UUID so I dig into active support and I found that all the core extensions have a file to include their respective files, but digest so I added it.

Other Information

I think the expected behaviour is to have Digest::UUID available for use so I don't think I should change changelogs or docs.

Thanks

@lucasprag
Copy link
Copy Markdown
Contributor Author

To be more clear about my fix, before:
Screen Shot 2019-06-12 at 4 50 19 PM

after:
Screen Shot 2019-06-12 at 4 51 38 PM

@rafaelfranca rafaelfranca merged commit 0ad238f into rails:master Jun 12, 2019
rafaelfranca added a commit that referenced this pull request Jun 12, 2019
…e-digest

Add missing file to require digest/uuid on active_support core ext
rafaelfranca added a commit that referenced this pull request Jun 12, 2019
…e-digest

Add missing file to require digest/uuid on active_support core ext
suketa added a commit to suketa/rails_sandbox that referenced this pull request Oct 21, 2019
Add missing file to require digest/uuid on active_support core ext
rails/rails#36470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants