Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `relation.exists?` with giving `distinct`, `offset` and `order` for joined table #36647

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@giraffate
Copy link
Contributor

commented Jul 10, 2019

Summary

Fix relation.exists? with giving distinct, offset and order for joined table

The error happens in PostgreSQL when using relation.exists? with
distinct, offset and order for joined table.
However, the error does not happen if either distinct or offset is
removed. This behavior is confusing.

Fixes #36632

Fix `relation.exists?` with giving `distinct`, `offset` and `order` f…
…or joined table

The error happens in PostgreSQL when using `relation.exists?` with
`distinct`, `offset` and `order` for joined table.
However, the error does not happen if either `distinct` or `offset` is
removed. This behavior is confusing.

Fixes #36632

@rails-bot rails-bot bot added the activerecord label Jul 10, 2019

@kamipo kamipo merged commit d9587fe into rails:master Jul 11, 2019

2 checks passed

buildkite/rails Build #62130 passed (9 minutes, 34 seconds)
Details
codeclimate All good!
Details

kamipo added a commit that referenced this pull request Jul 11, 2019

Merge pull request #36647 from giraffate/fix_exists_with_distinct_and…
…_offset_and_order_in_postgresql

Fix `relation.exists?` with giving `distinct`, `offset` and `order` for joined table

kamipo added a commit that referenced this pull request Jul 11, 2019

Merge pull request #36647 from giraffate/fix_exists_with_distinct_and…
…_offset_and_order_in_postgresql

Fix `relation.exists?` with giving `distinct`, `offset` and `order` for joined table

kamipo added a commit that referenced this pull request Jul 11, 2019

Merge pull request #36647 from giraffate/fix_exists_with_distinct_and…
…_offset_and_order_in_postgresql

Fix `relation.exists?` with giving `distinct`, `offset` and `order` for joined table

@giraffate giraffate deleted the giraffate:fix_exists_with_distinct_and_offset_and_order_in_postgresql branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.