Add delete_multi method to cache
#36927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy
reviewed
Aug 14, 2019
Nice feature! Observe the interaction between read_multi (public API implemented once in base class) and read_multi_entries (private implementation; default in base class, overridden in subclasses). You can follow this pattern with delete_multi (public API) and delete_multi_entries (private implementation) as well.
peterzhu2118
force-pushed
the
cache-delete-multi
branch
4 times, most recently
from
e0bcb4e
to
a862d59
Compare
|
Hey @jeremy, thanks for the review! I've updated the implementation with your suggestions, please take another look! |
peterzhu2118
force-pushed
the
cache-delete-multi
branch
from
a862d59
to
a78958d
Compare
|
Hey @jeremy, could I get another review please? |
jeremy
reviewed
Aug 20, 2019
peterzhu2118
force-pushed
the
cache-delete-multi
branch
from
a78958d
to
ff611b4
Compare
|
Awesome! We used a custom implementation and can now switch back to the default again! Thanks @peterzhu2118 |
n-rodriguez
reviewed
Sep 30, 2019
| @cache.write("foo", "bar") | ||
| assert @cache.exist?("foo") | ||
| @cache.write("hello", "world") | ||
| assert @cache.exist?("foo") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Summary
Adds
ActiveSupport::Cache::Store#delete_multito delete an array of keys from the cache.For most implementations, this just calls
ActiveSupport::Cache::Store#deletentimes, but Redis supports deleting an array of keys. This can improve performance because it turns what is previouslyndelete calls into a single call.Memcached does not support multi delete.