Hi, I been working on this:
but I figured out that the last changes on activeresource maybe will broke my
patch, so I forked rails and I did my commits on my fork on master and 3-0-stable, I'm going to apply my changes for 2.3 soon I will send it a new pull request.
Thanks in advance.
- elmenth_path raise an ActiveResource::MissingPrefixParam exception …
…when prefix_options does not has all required prefix_options ex: class StreetAddress < ActiveResource::Base self.site = "http://37s.sunrise.i:3000/people/:person_id/" end
# => ActiveResource::MissingPrefixParam
- refactoring, move prefix_options check to a custom method
- better name for prefix param test case
- check prefix options in collection_path
- update exceptions documentation
- added mock to test ActiveResource::MissingPrefixParam in finder_test
Merge remote branch 'upstream/master'
Hey, nice work.
I'll pull in and test it out today.
Ideally, your pull request wouldn't have a merge commit in there. Please in the future rebase your work. Makes life easier for me in committing.
Thanks for the advice!
Do you need that I remove the merge commit and do the pull request again?
Hi there Gramos,
I totally forgot about this.
If you could rebase against master without the merge, and do another pull request, that would be fantastic. I'll take a look at it tomorrow morning and see how we go.
As for associations, yes, good idea. For that I would request you post your idea to rails-core and have a discussion on the implementation first.
Thanks for your work, look forward to your pull request tomorrow morning my time :)
Fixed #37 - joining to '' has the same effect of adding a trailing sl…
…ash, works on Windows and *nix
Properly fixed #37