Skip to content

Active Resource should warn about missing prefix value #37

Closed
wants to merge 7 commits into from

2 participants

@gramos
gramos commented Sep 20, 2010

Hi, I been working on this:
https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/5631-activeresourcemissingprefixparam-proposal

but I figured out that the last changes on activeresource maybe will broke my
patch, so I forked rails and I did my commits on my fork on master and 3-0-stable, I'm going to apply my changes for 2.3 soon I will send it a new pull request.

Thanks in advance.

Gastón Ramos

@mikel
Ruby on Rails member
mikel commented Sep 22, 2010

Hey, nice work.

I'll pull in and test it out today.

@mikel
Ruby on Rails member
mikel commented Sep 22, 2010

Ideally, your pull request wouldn't have a merge commit in there. Please in the future rebase your work. Makes life easier for me in committing.

@gramos
gramos commented Sep 22, 2010

Thanks for the advice!

@gramos
gramos commented Sep 24, 2010

Do you need that I remove the merge commit and do the pull request again?

@mikel
Ruby on Rails member
mikel commented Sep 27, 2010

Hi there Gramos,

I totally forgot about this.

If you could rebase against master without the merge, and do another pull request, that would be fantastic. I'll take a look at it tomorrow morning and see how we go.

As for associations, yes, good idea. For that I would request you post your idea to rails-core and have a discussion on the implementation first.

Thanks for your work, look forward to your pull request tomorrow morning my time :)

Mikel

@claudiob claudiob pushed a commit to claudiob/rails that referenced this pull request Sep 23, 2014
@ndbroadbent ndbroadbent Fixed #37 - joining to '' has the same effect of adding a trailing sl…
…ash, works on Windows and *nix
4f0e8ec
@claudiob claudiob pushed a commit to claudiob/rails that referenced this pull request Sep 23, 2014
@ndbroadbent ndbroadbent Properly fixed #37 52486ce
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.