Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coffee-rails update information to rails guides #37321

Conversation

@iarobinson
Copy link
Contributor

commented Sep 29, 2019

Summary

When upgrading from Rails 5.2 to 6.0, I found the following error:

DEPRECATION WARNING: Single arity template handlers are deprecated. Template handlers must
now accept two parameters, the view object and the source for the view object.
Change:
  >> Coffee::Rails::TemplateHandler.call(template)
To:
  >> Coffee::Rails::TemplateHandler.call(template, source)
 (called from <main> at /Users/MediocreManta/Desktop/freedom_podcasting/Rakefile:6)

The fix to this is to update your version of coffee-rails.

This PR adds instructions for upgrading coffee-rails in the instructions for migrating from Rails 5.2 to 6.0.

@rails-bot rails-bot bot added the docs label Sep 29, 2019
@kaspth

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

In this case, our update guides assume knowledge of bundle and how to update a particular gem, so I'm not really keen on adding this.

I'd tentatively consider merging a deprecation warning fix since the deprecation warning wrongly points to your app's Rakefile and the coffee-rails. But for now the warning does mention Coffee::Rails, so I'll close this particular PR. Thanks!

@kaspth kaspth closed this Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.