GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
This pull requests contains fixes for the first 2 points of the issue. I'd be glad to fix the other two problems if I receive a blessing from a core team member :).
I didn't want to squash the commits just yet to demonstrate two cases separately.
(See issue #3737 for more details)
Fix #3737 AS::expand_cache_key generates wrong key in certain situations
`cache_key` method is never called when the argument is a 1-element array
with something that responds to `cache_key`
Fix #3737 AS::expand_cache_key generates wrong key in certain situati…
…ons (part 2)
`nil` and `false` both expand to `""` (empty string), while `true` expands to
`"true"`; `false` should expand to `"false"`
Merge pull request #3738 from exviva/issues/3737_AS_cache_expand_cach…