Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Issues/3737 AS::Cache.expand_cache_key #3738

merged 2 commits into from Nov 23, 2011


None yet
2 participants

exviva commented Nov 23, 2011

This pull requests contains fixes for the first 2 points of the issue. I'd be glad to fix the other two problems if I receive a blessing from a core team member :).

I didn't want to squash the commits just yet to demonstrate two cases separately.

(See issue #3737 for more details)

exviva added some commits Nov 23, 2011

@exviva exviva Fix #3737 AS::expand_cache_key generates wrong key in certain situations
`cache_key` method is never called when the argument is a 1-element array
with something that responds to `cache_key`
@exviva exviva Fix #3737 AS::expand_cache_key generates wrong key in certain situati…
…ons (part 2)

`nil` and `false` both expand to `""` (empty string), while `true` expands to
`"true"`; `false` should expand to `"false"`

@josevalim josevalim added a commit that referenced this pull request Nov 23, 2011

@josevalim josevalim Merge pull request #3738 from exviva/issues/3737_AS_cache_expand_cach…

Issues/3737 AS::Cache.expand_cache_key

@josevalim josevalim merged commit 2c568f1 into rails:master Nov 23, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment