Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reestablish connection to previous database after migrating: #37601

Merged

Conversation

@Edouard-chin
Copy link
Contributor

Edouard-chin commented Oct 30, 2019

Reestablish connection to previous database after migrating:

  • The migrate task iterates and establish a connection over each db
    resulting in the last one to be used by subsequent rake tasks.
    We should reestablish a connection to the connection that was
    established before the migrate tasks was run
  • Fix #37578

cc/ @casperisfine @etiennebarrie @rafaelfranca

- The migrate task iterates and establish a connection over each db
  resulting in the last one to be used by subsequent rake tasks.
  We should reestablish a connection to the connection that was
  established before the migrate tasks was run
- Fix #37578
@eileencodes eileencodes merged commit cfd4bff into rails:master Nov 1, 2019
1 check passed
1 check passed
buildkite/rails Build #64635 passed (16 minutes, 41 seconds)
Details
eileencodes added a commit that referenced this pull request Nov 1, 2019
…migrating

Reestablish connection to previous database after migrating:
@eileencodes

This comment has been minimized.

Copy link
Member

eileencodes commented Nov 1, 2019

Thanks @Edouard-chin! Backported to 6.0 in 0221385

eileencodes added a commit that referenced this pull request Nov 1, 2019
Rubocop wants double quoted strings, not single. I missed this when I
merged #37601
eileencodes added a commit that referenced this pull request Nov 1, 2019
Rubocop wants double quoted strings, not single. I missed this when I
merged #37601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.