Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache gems for GitHub Actions #37612

Merged
merged 1 commit into from Nov 1, 2019

Conversation

@yahonda
Copy link
Contributor

yahonda commented Oct 31, 2019

Summary

This pull request adds cache for GitHub Actions

Follows up #37582

GitHub Actions cache requires path: parameter to configure which directory to be cached. It looks there is no easy way to retrieve path information using bundler command then workaround implemented to use vendor/bundle.

Thanks to actions/cache#4

Follows up #37582

GitHub Actions cache requires `path:` parameter to configure
which directory to be cached. It looks there is no easy way to retrieve path information
using bundler command then workaround implemented to use `vendor/bundle`.

Thanks to actions/cache#4
@yahonda yahonda force-pushed the yahonda:enable_actions_cache branch from 320e94f to 55f9c8a Oct 31, 2019
@yahonda

This comment has been minimized.

Copy link
Contributor Author

yahonda commented Nov 1, 2019

Running RuboCop finishes in 1 min now.

https://github.com/rails/rails/pull/37612/checks?check_run_id=284144170

RuboCop / build (pull_request) Successful in 1m
@y-yagi y-yagi merged commit 0b43409 into rails:master Nov 1, 2019
2 checks passed
2 checks passed
build
Details
buildkite/rails Build #64669 passed (15 minutes, 57 seconds)
Details
@kaspth

This comment has been minimized.

Copy link
Member

kaspth commented Nov 1, 2019

❤️ fantastic!

@chrispat

This comment has been minimized.

Copy link

chrispat commented Nov 1, 2019

@yahonda what was it before?

@kaspth

This comment has been minimized.

Copy link
Member

kaspth commented Nov 1, 2019

@chrispat around 7 min, see the original issue in the description for more 😊

@yahonda yahonda deleted the yahonda:enable_actions_cache branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.