Please pull my changes - they fix a rare problem with tests framework #3775

Merged
merged 1 commit into from Jan 24, 2012

Projects

None yet

5 participants

@ghost

Steps to reproduce:
1. Have routes with lambda-base :constraints option.
2. Have requests with subdomain set.
Defect: request parameters parsed are not available in the request object passed to :constraints lambda.

Tests included, not sure they are perfect.

@josevalim
Ruby on Rails member
@tendrelove

I'm on vacation bro, give me a few days before I check on that please.

@josevalim
Ruby on Rails member
@ghost

Take your time :)

@ghost

Any news, guys?

@Empact

Hey karevn, are you sure you need to fully-qualify that constant name?

@tenderlove tenderlove merged commit ad6f689 into rails:master Jan 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment