Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Turning on warnings in "rake test" for railties #3782

Merged
merged 1 commit into from
@arunagw
Collaborator

Showing warnings in log

@josevalim
Owner

Sweet, how verbose is it? A bunch of warnings or just a few?

@arunagw
Collaborator

There are a lot from thor. From Rails there are less.

@josevalim
Owner
@arunagw
Collaborator

Yeah. That can be done. Let me give a try for that. :-)

Thanks :-)

@josevalim
Owner
@arunagw
Collaborator

My First Attack is Rack-cache : rtomayko/rack-cache#43

Attacking more.

@henrikhodne

Sweet, I usually just do export RUBYOPT="-w", but this is nicer. Also, many of the warnings already have pull requests to fix them.

@arunagw
Collaborator

I have one more here to fix warning.
@josevalim i think this can go anytime

#3278

I have created a branch in Mail gem to fix some of the warnings. Hope we will get that merged soon
https://github.com/mikel/mail/tree/warning_fixes

@arunagw
Collaborator

@josevalim I think you going to need to rc for thor which I can test out. Most of the warning already fixed in 0.15.0.rc2. :-)

@parndt

+1 I'd love to see this merged in master that we're made very aware of all warnings so that we can fix them before 4.0.0 :-)

@arunagw
Collaborator

We have left with some rake and mail gem warnings and one from us only!

But it's still verbose for each test in a file.

@arunagw
Collaborator

OMG there are a lot from thor still!!

@sikachu
Collaborator

It has been two months. How are we doing on this?

@arunagw
Collaborator

I recently see this and we still have thor warnings. If that can be removed then this PR is good to go.

@josevalim
Owner

They just released Thor 0.15.0. Maybe we should run rails tests with it and see if it reduces the amount of warnings?

@arunagw
Collaborator

So we have some warnings

rake

/Users/arunagw/checkouts/rails/bundle/ruby/1.9.1/gems/rake-0.9.2.2/lib/rake/file_list.rb:350: warning: method redefined; discarding old exclude?
/Users/arunagw/checkouts/rails/bundle/ruby/1.9.1/gems/rake-0.9.2.2/lib/rake/file_list.rb:77: warning: previous definition of exclude? was here

and from our code

/Users/arunagw/checkouts/rails/railties/lib/rails/deprecation.rb:6

and also 4-5 from our code for method redefined. Can we removed that also first?

@schneems
Collaborator

@arunagw what is the state of this issue? Making progress, stuck on something? What are the blockers left for merge.

@steveklabnik
Collaborator

What's up with this?

@arunagw
Collaborator

I rebased with latest master. Just looked tests again with warning mode on. There are few from Bundler and Benchmark-ips. And for others itself from Rails I will do a PR for that. I think it's good to go.

@schneems
Collaborator

This looks good to me, thanks @arunagw, if you still have the warnings could you paste them in here? We can pass that info along to the appropriate libraries so they might be able to work on them.

@arunagw
Collaborator

Major is

/Users/arunagw/checkouts/rails/bundle/ruby/1.9.1/gems/benchmark-ips-1.2.0/lib/benchmark/ips.rb:240: warning: assigned but unused variable - seconds


/Users/arunagw/checkouts/rails/railties/lib/rails/deprecation.rb:6: warning: assigned but unused variable - constant

@rafaelfranca

Can't we fix the railties/lib/rails/deprecation.rb:6 ?

@frodsan

@rafaelfranca I think Steve fixed that warning. Is it ready?

@arunagw
Collaborator

Yes that's fixed.

Here is summary from latest run

  1. I did a PR here which needs to merge evanphx/benchmark-ips#5

  2. Latest changes from in master got this warning warning: previous definition of include_root_in_json was here

  3. And there are few from sprockets-rails.

@guilleiguaran

feel free to send any PR to sprockets-rails, I will merge immediately :)

@arunagw
Collaborator

@guilleiguaran that's nice. Let me give a try!

@senny
Owner

ping.

What is the status on this one?

@spastorino spastorino merged commit 62affac into rails:master
@arunagw arunagw deleted the arunagw:warning_mode_on branch
@arunagw arunagw restored the arunagw:warning_mode_on branch
@sgerrand sgerrand referenced this pull request from a commit in sgerrand/rails
@arunagw arunagw Few more warnings removed.
I found them when I was running
warning mode on with railties

See rails#3782
ff04bb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 1, 2013
  1. @arunagw
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  railties/Rakefile
View
2  railties/Rakefile
@@ -22,7 +22,7 @@ namespace :test do
"#{File.dirname(__FILE__)}/../actionpack/lib",
"#{File.dirname(__FILE__)}/../activemodel/lib"
]
- ruby "-I#{dash_i.join ':'}", file
+ ruby "-w", "-I#{dash_i.join ':'}", file
end
end
end
Something went wrong with that request. Please try again.