Showing warnings in log
Sweet, how verbose is it? A bunch of warnings or just a few?
There are a lot from thor. From Rails there are less.
Yeah. That can be done. Let me give a try for that. :-)
My First Attack is Rack-cache : rtomayko/rack-cache#43
Sweet, I usually just do export RUBYOPT="-w", but this is nicer. Also, many of the warnings already have pull requests to fix them.
I have one more here to fix warning.
@josevalim i think this can go anytime
I have created a branch in Mail gem to fix some of the warnings. Hope we will get that merged soon
@josevalim I think you going to need to rc for thor which I can test out. Most of the warning already fixed in 0.15.0.rc2. :-)
+1 I'd love to see this merged in master that we're made very aware of all warnings so that we can fix them before 4.0.0 :-)
We have left with some rake and mail gem warnings and one from us only!
But it's still verbose for each test in a file.
OMG there are a lot from thor still!!
It has been two months. How are we doing on this?
I recently see this and we still have thor warnings. If that can be removed then this PR is good to go.
They just released Thor 0.15.0. Maybe we should run rails tests with it and see if it reduces the amount of warnings?
So we have some warnings
/Users/arunagw/checkouts/rails/bundle/ruby/1.9.1/gems/rake-0.9.2.2/lib/rake/file_list.rb:350: warning: method redefined; discarding old exclude?
/Users/arunagw/checkouts/rails/bundle/ruby/1.9.1/gems/rake-0.9.2.2/lib/rake/file_list.rb:77: warning: previous definition of exclude? was here
and from our code
and also 4-5 from our code for method redefined. Can we removed that also first?
@arunagw what is the state of this issue? Making progress, stuck on something? What are the blockers left for merge.
What's up with this?
I rebased with latest master. Just looked tests again with warning mode on. There are few from Bundler and Benchmark-ips. And for others itself from Rails I will do a PR for that. I think it's good to go.
This looks good to me, thanks @arunagw, if you still have the warnings could you paste them in here? We can pass that info along to the appropriate libraries so they might be able to work on them.
/Users/arunagw/checkouts/rails/bundle/ruby/1.9.1/gems/benchmark-ips-1.2.0/lib/benchmark/ips.rb:240: warning: assigned but unused variable - seconds
/Users/arunagw/checkouts/rails/railties/lib/rails/deprecation.rb:6: warning: assigned but unused variable - constant
Can't we fix the railties/lib/rails/deprecation.rb:6 ?
@rafaelfranca I think Steve fixed that warning. Is it ready?
Yes that's fixed.
Here is summary from latest run
I did a PR here which needs to merge evanphx/benchmark-ips#5
Latest changes from in master got this warning warning: previous definition of include_root_in_json was here
warning: previous definition of include_root_in_json was here
And there are few from sprockets-rails.
feel free to send any PR to sprockets-rails, I will merge immediately :)
@guilleiguaran that's nice. Let me give a try!
Turning on warnings in "rake test" for railties
What is the status on this one?
Few more warnings removed.
I found them when I was running
warning mode on with railties