Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ActiveStorage::Blob → ActionText::TrixAttachment conversion #37868

Merged

Conversation

@javan
Copy link
Member

javan commented Dec 3, 2019

A regression introduced in 764803e caused blobs to appear as HTML content attachments instead of file / image attachments when editing rich text content. This change restores the original intended behavior.

References: #35485, basecamp/trix#706

A regression introduced in 764803e caused blobs to appear as HTML content attachments instead of file / image attachments when editing rich text content. This change restores the original intended behavior.

References: #35485, basecamp/trix#706
@javan javan merged commit 4e701b4 into rails:master Dec 3, 2019
2 checks passed
2 checks passed
build
Details
buildkite/rails Build #65285 passed (1 hour, 7 minutes)
Details
@javan javan deleted the javan:actiontext/blobs-are-not-content-attachments branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.