Action Text: Add method to confirm rich text content existence by adding ? after content name #37951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontent name This change introduces a rich text object to make it easier to confirm it context is existing or not. If we have a class like below. class Information < ApplicationRecord has_rich_text :notes end Before: i = Information.new i.notes? => NoMethodError i.notes = "Some sample text" i.notes.present? => true After: i = Information.new i.notes? => false i.notes = "Some sample text" i.notes? => true
t0yohei
force-pushed
the
add-missing-action-to-action-text
branch
from
5c18fe6 to
07533a3
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
abhaynikam
added a commit
to abhaynikam/rails
that referenced
this pull request
Jun 3, 2021
Similar to: rails#37951 Example: ``` class User < ActiveRecord::Base has_one_attached :avatar has_many_attached :documents end ``` Before: ``` user = User.create! user.avatar.attached? # => false user.documents.attached? # => true ``` After: ``` user.avatar? # => false user.documents? # => true ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the pull request based on #37594
This change introduces a rich text object to make
it easier to confirm it context is existing or not.
Other Information
If we have a class like below.
Before:
After: