Skip to content

adding html5 input types for datetime, datetime-local, date, month, week... #3826

Closed
wants to merge 1 commit into from

6 participants

@yopefonic

... and time to the form and form_tag helpers.

The current form_helper and form_tag_helper in actionpack were not supporting the HTML5 input types for dates and time.

HTML5 spec reference can be found here: http://dev.w3.org/html5/spec/Overview.html#states-of-the-type-attribute

@vijaydev
Ruby on Rails member
vijaydev commented Dec 2, 2011

Can you also update the guide please?

@yopefonic

Sure, I'll try to get it do it today.

@yopefonic

I did not find any other mentioning of the email, url and other fields so I added it just to that section of the guides

@timonv
timonv commented Dec 2, 2011

Cool that you actually did this :-) You really should rebase the merge commit and squash 2a68797 to 12dcc7a.

@yopefonic

squashed

@yopefonic

is there anything else that needs to be done on this patch?

@carlosantoniodasilva
Ruby on Rails member

This sounds good, @yopefonic could you please bring this up to date with current master, using the new Tags classes? Thanks.

@yopefonic

Sorry for the late response but it's been a chaos week for me. I'll try and get to it this week.

@carlosantoniodasilva
Ruby on Rails member

Related to #5065

@drogus
Ruby on Rails member
drogus commented May 11, 2012

@yopefonic have you had time to work on this? If don't have the time to finish this, I can take over it.

@yopefonic

I have not been able to spend any time on it last month and I'm in a crunch for at least one more week. If you want to pick it up and rebase it to get it back up to spec

@carlosgaldino carlosgaldino referenced this pull request May 17, 2012
Merged

Add HTML5 inputs #6359

@rafaelfranca
Ruby on Rails member

Closed by #6359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.