Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the environment.rb file path in the benchmark generator template #38378

Merged

Conversation

@bknarendra
Copy link
Contributor

bknarendra commented Feb 3, 2020

The environment.rb file path in the benchmark generator template is incorrect. So if we generate a benchmark file using benchmark generator and run it. It throws an error

Traceback (most recent call last):
	1: from script/benchmarks/opt_compare.rb:3:in `<main>'
script/benchmarks/opt_compare.rb:3:in `require_relative': cannot load such file -- /path/to/rails_repo/script/config/environment (LoadError)

This PR fixes this path.

@rails-bot rails-bot bot added the railties label Feb 3, 2020
@tenderlove tenderlove merged commit b693829 into rails:master Feb 3, 2020
2 checks passed
2 checks passed
build
Details
buildkite/rails Build #66799 passed (17 minutes, 20 seconds)
Details
@bknarendra bknarendra deleted the bknarendra:fix_template_for_benchmark_generator branch Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.