Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Expose Marshal as a legit SchemaCache serialization strategy #38432
This lets people choose between
The default behavior is still YAML.
The Marshal behavior was replaced with YAML in 2016, and then in 2019 an attempt was made to remove it. It was put back the next day. In #38347 I suggested deprecating it, since it seemed like the intention was to be able to remove it, though I had not found any issues/PRs discussing it.
@tenderlove suggested that instead of removing it, we should make it configurable.
Here I've pushed the load and dump behavior into the schema class itself, in order to group the serialization logic somewhat.
I paired with @seejohnrun to figure out the failing builds. It turns out that moving the
I think we've sorted it out (waiting for the builds to finish).
@tenderlove you were right about the speed issue (obviously, in hindsight :-))
This runs 500 iterations through dumping and loading all of our databases on GitHub dotcom locally on my computer.