Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

No Verbose the output for test. #3892

Merged
merged 1 commit into from

4 participants

@arunagw
Collaborator

removing verbose from other also

@arunagw
Collaborator

Just as others. In other we have verbose flag true

@kennyj
Collaborator

+1

@kennyj
Collaborator

@arunagw I had mistake...
I think that we should set t.verbose = false in all modules.
actionmailer and activemodel (, and so on) is so quiet. I like them.

@arunagw
Collaborator

I am ok with that also!

Should i update this one?

@kennyj
Collaborator

Yes !

@arunagw
Collaborator

@kennyj updated. Instead of doing false we can just remove them. Removed.

@kennyj
Collaborator

Great ! I'll become a resident of the quiet country.

@josevalim josevalim merged commit 593fe43 into rails:master
@tenderlove
Owner

Why are we changing this? Seeing the command that's run is useful to me.

@tenderlove
Owner

Two counterarguments to this pull request:

  1. If we're going to make it consistent, why not make it consistently verbose?
  2. "A foolish consistency is the hobgoblin of little minds"
@josevalim
Owner
@kennyj
Collaborator

I just was wondering the difference.
And I was having a question "AM is quiet. Why?"
Thus I wanted to get consistency.

If we set verbose = false, I thought the output included everything I need to watch.
warnings, test result, the cause of problem...

Anyway I agree with fixing master.

@tenderlove
Owner
@arunagw
Collaborator

At first point i made all verbose. But as per comments i made them non verbose. I will do a PR for making them all verbose.

@arunagw arunagw referenced this pull request from a commit in arunagw/rails
@arunagw arunagw Verbose output for tests.
See #3892
bfb84cf
@arunagw arunagw referenced this pull request
Merged

Verbose output for tests. #4861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 1, 2012
  1. @arunagw
This page is out of date. Refresh to see the latest.
View
1  actionpack/Rakefile
@@ -19,7 +19,6 @@ Rake::TestTask.new(:test_action_pack) do |t|
t.test_files = Dir.glob('test/{abstract,controller,dispatch,template,assertions}/**/*_test.rb').sort
t.warning = true
- t.verbose = true
end
namespace :test do
View
1  activerecord/Rakefile
@@ -48,7 +48,6 @@ end
|x| x =~ /\/adapters\//
} + Dir.glob("test/cases/adapters/#{adapter_short}/**/*_test.rb")).sort
- t.verbose = true
t.warning = true
}
View
1  activesupport/Rakefile
@@ -6,7 +6,6 @@ Rake::TestTask.new do |t|
t.libs << 'test'
t.pattern = 'test/**/*_test.rb'
t.warning = true
- t.verbose = true
end
namespace :test do
Something went wrong with that request. Please try again.