New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add special case inflection for 'save' -> 'saves' #3910

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@planetcohen
Copy link

planetcohen commented Dec 8, 2011

The noun 'saves' should be singularized as 'save' (as in "the pitcher now has 43 saves on the season, since he earned another save last night"). It was being singularized as 'safe'. This commit fixes this issue.

@josevalim

This comment has been minimized.

Copy link
Contributor

josevalim commented Dec 8, 2011

Thanks but we don't add more inflection rules to Rails.

@josevalim josevalim closed this Dec 8, 2011

@planetcohen

This comment has been minimized.

Copy link
Author

planetcohen commented Dec 8, 2011

So how do you deal with broken inflections in Rails?

On 12/8/11 9:40 AM, "José Valim"
<reply+i-2490624-c45f2c0acd2f05612c1a4b318fbf7aebbfa2494a-265783@reply.gith
ub.com> wrote:

Thanks but we don't add more inflection rules to Rails.


Reply to this email directly or view it on GitHub:
#3910 (comment)

@josevalim

This comment has been minimized.

Copy link
Contributor

josevalim commented Dec 8, 2011

Add the inflection in your app in the config/initializers/inflection.rb. Rails cannot possibly include all inflections by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment