Fixed odd behavior of inverse_of with multiple belongs_to to same class

[ktmouk]

Fix: #35204.

This PR added validation to automatic_inverse_of that foreign_keys are the same.

If class has multiple belongs_to to same class, automatic_inverse_of can find the wrong inverse_name.

class Room < ActiveRecord::Base
  belongs_to :user
  belongs_to :owner, class_name: "User"
end

class User < ActiveRecord::Base
  has_one :room
  has_one :owned_room, class_name: "Room", foreign_key: "owner_id"
end

user = User.create!
owned_room = Room.create!(owner: user)

p user.room

The current automatic_inverse_of validates the reflection that found from associations.
However, its validation does not validate that foreign keys are the same.

so this issue can be fixed by adding a validation of foreign keys.

[kamipo]

As I said in the Slack, can you elaborate on the context bit more in the commit message?

I know the context that what is the cause and a way to prevent the issue, but it is preferable to share the context for other reviewers and future readers.

[kamipo]

user = User.create!
owned_room = Room.create!(owner: owned_room)

Typo s/owned_room/user/

user = User.create!
owned_room = Room.create!(owner: user)

[kamipo]

Thank you and congrats for your first contribution 🎉

[ktmouk]

Thank you, too!