Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix regression in select form helper when options are non-string values #4080

Merged
merged 2 commits into from Dec 20, 2011

Conversation

Projects
None yet
2 participants
Contributor

heimidal commented Dec 20, 2011

This is a fix for #4048

Contributor

josevalim commented Dec 20, 2011

Shouldn't it be respond_to?(:last)?

Contributor

heimidal commented Dec 20, 2011

Yup. Too many firsts/lasts, and the tests passed either way since it's Enumerable. New commit incoming.

josevalim added a commit that referenced this pull request Dec 20, 2011

Merge pull request #4080 from heimidal/3-2-stable
Fix regression in select form helper when options are non-string values

@josevalim josevalim merged commit a2f5df5 into rails:3-2-stable Dec 20, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment