Quote the arguments passed to the Contains/Overlaps Arel nodes #41640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… align with the behaviour of existing predicates
pixeltrix
pushed a commit
that referenced
this pull request
Mar 27, 2021
Quote the arguments passed to the Contains/Overlaps Arel nodes (cherry picked from commit 982ed41)
pixeltrix
added a commit
that referenced
this pull request
Mar 28, 2021
pixeltrix
added a commit
that referenced
this pull request
Mar 28, 2021
pixeltrix
added a commit
that referenced
this pull request
Mar 28, 2021
Add CHANGELOG entry for #41640
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#39246 by @alassek added
Arel::Nodes::ContainsandArel::Nodes::Overlapsto the arel library.This PR updates the predicate implementation slightly to also support the automatic quoting of values into Arel to match how the other predicates work.
Other Information
The test implementation leaves a bit to be desired, but I couldn't think of a better way to test this without reaching across boundaries