Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

deprecate Base64.encode64s from AS #4207

Merged
merged 1 commit into from Dec 28, 2011

Conversation

Projects
None yet
3 participants
Contributor

nashby commented Dec 27, 2011

Use Base64.strict_encode64 instead.
BTW, should we use plain encode64, decode64, etc from Base64 not from ActiveSupport::Base64?

Contributor

lest commented Dec 27, 2011

If we deprecate encode64s then nothing else lasts in ActiveSupport::Base64.
Maybe deprecate ActiveSupport::Base64 entirely?

/cc @fxn

Owner

tenderlove commented Dec 28, 2011

@lest yes, we should deprecate the constant all together.

@tenderlove tenderlove added a commit that referenced this pull request Dec 28, 2011

@tenderlove tenderlove Merge pull request #4207 from nashby/deprecate-base64-encode64s
deprecate Base64.encode64s from AS
afe6e05

@tenderlove tenderlove merged commit afe6e05 into rails:master Dec 28, 2011

Contributor

lest commented Jan 1, 2012

@tenderlove I've deprecated the constant in #4252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment