Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the new Active Support cache format #42076

Merged
merged 1 commit into from Apr 26, 2021

Conversation

casperisfine
Copy link
Contributor

Followup: #42025

Hopefully this is clear enough?

I also think we should immediately deprecate the 6.1 format as it constrain the Entry internal state preventing various cleanup and optimizations. Not sure what the window should be though, Rails 7.2 ?

cc @rafaelfranca @fxn ?

@fxn
Copy link
Member

fxn commented Apr 26, 2021

@casperisfine In principle 7.2 could be a good compromise, I think.

So, we could issue a deprecation warning if 6.1 format is configured in a 7.1 application, and remove support in 7.2. I guess with such a wide time span caches are unlikely to have old entries, which is important because that would become an error condition. However, unless you scan the cache I guess you cannot have certainty in a generic situation?

@casperisfine
Copy link
Contributor Author

Ok, sounds good. I'll add a deprecation once 7.0 is out.

@byroot byroot merged commit 0beae87 into rails:main Apr 26, 2021
@casperisfine casperisfine deleted the document-as-cache-upgrade branch April 26, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants