Don't hide _method param in logs; Issue #426 #427

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

dlee commented May 7, 2011

Hiding the _method param leaves no indication in the Rails log that a request
would be interpreted by the Rails app according to the method override.

Don't hide _method param in logs; Issue #426
Hiding the _method param leaves no indication in the Rails log that a request
would be interpreted by the Rails app according to the method override.
Owner

dhh commented May 7, 2011

The Rails log already shows you what kind of a request it is. We don't need to repeat this again in the log by exposing _method. Teaching people that it's there is a 1-time piece of information that's not worth cluttering the log with for all time thereafter.

@dhh dhh closed this May 7, 2011

Contributor

dlee commented May 7, 2011

So you're saying issue #426 is not reproducible?

I don't see any indication in the Rails log that tells me that a PUT request is a PUT request.

Owner

dhh commented May 7, 2011

Yeah, I see the problem. We should fix that at its root rather than get _method in there.

Contributor

dlee commented May 7, 2011

Ah, didn't realize it was a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment