Fix dirty check for Float::NaN and BigDecimal::NaN #42831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
reviewed
Jul 21, 2021
marcelolx
force-pushed
the
fix_dirty_check_for_nan
branch
3 times, most recently
from
07a5d2f to
76b7616
Compare
byroot
reviewed
Jul 22, 2021
byroot
reviewed
Jul 22, 2021
marcelolx
force-pushed
the
fix_dirty_check_for_nan
branch
3 times, most recently
from
568dc57 to
9dddae1
Compare
byroot
reviewed
Jul 22, 2021
Float::NaN and BigDecimal::NaN in Ruby are [special values](https://bugs.ruby-lang.org/issues/1720) and can't be compared with `==`.
marcelolx
force-pushed
the
fix_dirty_check_for_nan
branch
from
9dddae1 to
d1df4c1
Compare
byroot
approved these changes
Jul 22, 2021
|
Thank you! |
|
Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Float::NaN and BigDecimal::NaN in Ruby are special values and can't be compared with
==.Executable test case https://gist.github.com/marcelolx/ade29cd2fac0017dec3b667555b9454d
Closes #41663