"Middleware#remove" is renamed "Middleware#delete!" #42867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit intends to clarify the difference between `Middleware#delete` and `Middleware#delete!`. The former method silently fails when the target item is not found, while the latter raises an error. The functionality of `delete!` has been introduced in 688ed70 and given a name `remove`. This commit only renames it. Also, a brief description of `delete!` method is now provided for guides so that users can acknowledge the difference.
marivaldo
reviewed
Jul 25, 2021
p8
requested changes
Jul 25, 2021
| @@ -133,7 +133,7 @@ def delete(target) | |||
| middlewares.reject! { |m| m.name == target.name } | |||
| end | |||
|
|
|||
| def remove(target) | |||
| def delete!(target) | |||
There was a problem hiding this comment.
Could you also add some rdocs for delete! and delete?
Co-authored-by: Marivaldo Cavalheiro <marivaldo@gmail.com>
|
@marivaldo @p8 |
marivaldo
approved these changes
Jul 26, 2021
p8
requested changes
Jul 26, 2021
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Petrik de Heus <petrik@deheus.net>
|
@morgoth what do you think? |
|
@p8 I find it much more clear. 👍 |
|
@morgoth Great! 🎉 |
p8
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit intends to clarify the difference between
Middleware#deleteandMiddleware#delete!.The former method silently fails when the target item is
not found, while the latter raises an error.
The functionality of
delete!has been introduced in 688ed70and given a name
remove. This commit only renames it.Also, a brief description of
delete!method is nowprovided for guides so that users can acknowledge the difference.
Resolves #42862