-
Notifications
You must be signed in to change notification settings - Fork 21.9k
Instrument ActiveStorage analyzers #42939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This looks great! Can you rebase and add a Changelog entry? |
Could you also add it to the guides? 🙏 |
9e32e8b
to
3fb656c
Compare
3fb656c
to
f07c73e
Compare
Hi, @p8 thanks for the review! Rebased and made the following changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also rebase on main
to hopefully fix the unrelated spelling warnings?
f07c73e
to
35d8890
Compare
Rebased 👍 |
Thanks! The build failures seem unrelated :/ |
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Summary
This PR adds instrumentations to ActiveStorage analyzers so that the time of analysis can be tracked.
Close #42930.
Other Information
The following things should be agreed upon before merging.
CurrentlyChanged toanalyzer.active_storage
but should we include analyzer name?analyze.active_storage
so that it is consistent with others.Also, we may want to add the new event to the active support instrumentation document.
Thanks.