Moved the logger methods in activeresource/test/abstract_unit.rb #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Karunakar can you change all the logger lines on Rails and make them use AS::Logger please? |
|
@spastorino I have changed in all the files. |
| @@ -786,7 +786,7 @@ def setup | |||
| @cache = ActiveSupport::Cache.lookup_store(:memory_store) | |||
|
|
|||
| @buffer = StringIO.new | |||
| @cache.logger = Logger.new(@buffer) | |||
| @cache.logger =ActiveSupport::Logger.new(@buffer) | |||
|
And squash all the commits in one please. Thanks for the work! |
|
Thanks done. Seems that we can get rid of the ./lib/active_support/buffered_logger.rb. Deleting this in next commit. |
| @@ -206,7 +206,7 @@ A short rundown of some of the major features: | |||
|
|
|||
| You specify a logger through a class method, such as: | |||
|
|
|||
| ActionController::Base.logger = Logger.new("Application Log") | |||
| ActionController::Base.logger = AcitveSupport::Logger.new("Application Log") | |||
|
@jonasschneider & @spastorino Its my bad,Thanks. can we get rid of ./lib/active_support/buffered_logger.rb and related stuff |
spastorino
added a commit
that referenced
this pull request
Jan 5, 2012
Moved the logger methods in activeresource/test/abstract_unit.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the logger methods to active support logger methods in activeresource/test/abstract_unit.rb