Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Moved the logger methods in activeresource/test/abstract_unit.rb #4303

Merged
merged 1 commit into from Jan 5, 2012

Conversation

Projects
None yet
3 participants
Contributor

Karunakar commented Jan 4, 2012

Moved the logger methods to active support logger methods in activeresource/test/abstract_unit.rb

Owner

spastorino commented Jan 4, 2012

@Karunakar can you change all the logger lines on Rails and make them use AS::Logger please?
Thanks.

Contributor

Karunakar commented Jan 5, 2012

@spastorino I have changed in all the files.

@spastorino spastorino commented on an outdated diff Jan 5, 2012

activesupport/test/caching_test.rb
@@ -786,7 +786,7 @@ def setup
@cache = ActiveSupport::Cache.lookup_store(:memory_store)
@buffer = StringIO.new
- @cache.logger = Logger.new(@buffer)
+ @cache.logger =ActiveSupport::Logger.new(@buffer)
@spastorino

spastorino Jan 5, 2012

Owner

Add a space here :)

Owner

spastorino commented Jan 5, 2012

And squash all the commits in one please. Thanks for the work!

Contributor

Karunakar commented Jan 5, 2012

Thanks done. Seems that we can get rid of the ./lib/active_support/buffered_logger.rb. Deleting this in next commit.
is that ok?

@jonasschneider jonasschneider commented on an outdated diff Jan 5, 2012

actionpack/README.rdoc
@@ -206,7 +206,7 @@ A short rundown of some of the major features:
You specify a logger through a class method, such as:
- ActionController::Base.logger = Logger.new("Application Log")
+ ActionController::Base.logger = AcitveSupport::Logger.new("Application Log")
@jonasschneider

jonasschneider Jan 5, 2012

small typo here ;)

Contributor

Karunakar commented Jan 5, 2012

@jonasschneider & @spastorino Its my bad,Thanks. can we get rid of ./lib/active_support/buffered_logger.rb and related stuff

spastorino added a commit that referenced this pull request Jan 5, 2012

Merge pull request #4303 from Karunakar/logger
Moved the logger methods in activeresource/test/abstract_unit.rb

@spastorino spastorino merged commit 013d959 into rails:master Jan 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment