Drop orphan methods in AS::Dependencies #43048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefannibrasil
pushed a commit
to Kit/cequel
that referenced
this pull request
Jan 23, 2024
These dependencies have been removed in Rails 7.0: rails/rails#43048 that's why we get an error when running db:migrate on the main app.
stefannibrasil
pushed a commit
to Kit/cequel
that referenced
this pull request
Jan 24, 2024
When we bump the app's Rails version, we get an error when Rails tries to call `ActiveSupport::Dependencies::WatchStack`. Those dependencies have been removed from Rails > 7: rails/rails#43048 These dependencies were used before zeitwerk, so we don't need them anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the deletion of
classicmode, a lot of private interface becomes orphan and falls in cascade.(The CHANGELOG will be edited later.)