Don't overwrite default opts in rich_text_area_tag #43156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceritium
approved these changes
Sep 4, 2021
Contributor
Author
|
Hey @zzak—sorry for the cold ping. I don't know who's maintaining ActionText, but I saw you participating in quite a few issues. Do you have any thoughts on this PR, or maybe point me to the right person? Thanks! |
ghiculescu
reviewed
Sep 17, 2021
Member
|
The PR seems fine, can you please fix the merge conflict. I also made a suggestion for the CHANGELOG to make it a bit more clear. Action Text is maintained by the core team, who maintain all features of Rails. (zzak isn't on that team, I'm not either.) They do get to these PRs but they are super busy (with Rails + real jobs) so there's no guarantee how quickly they will. Sit tight :) |
Member
|
Could you squash please? https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#squashing-commits |
You may want to use your own controller to authenticate requests or perform server-side validations.
lmansur
force-pushed
the
rich-text-tag-dont-overwrite-opts
branch
from
1ab2578 to
560f26b
Compare
ceritium
approved these changes
Sep 17, 2021
dhh
pushed a commit
that referenced
this pull request
Sep 20, 2021
* main: [ci skip] Add Bootstrap and Bulma to the CSS processors' list (#43254) Add missing configuration to middleware test Add ActionDispatch::ServerTiming to the list of middlewares in test Add CHANGELOG entry for ServerTiming middleware [ci skip] Add Server Timing middleware (#36289) Don't overwrite default opts in rich_text_area_tag (#43156) Only call `wrap_parameters` if it's defined (#43259) Suggest a CSP that's compatible with Turbo + import map (#43227) Fix app generator tests Fix docs spacing Fix typo: integer numbers (not integral) Add `beginning_of_week` option to `weekday_options_for_select` Pluralize the heading on the index page generated with scaffold Move the parameter wrapper code to the ActionController::Railtie class Add explicit rendering to DiskController#update Fix update & destroy queries when default_scope is nillable with all_queries: true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You may want to use your own controller to authenticate requests or
perform server-side validations.