Fix flaky tests, add a template per case on asset debugging tests #43188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p8
reviewed
Sep 8, 2021
p8
reviewed
Sep 8, 2021
ceritium
changed the title
rafaelfranca
reviewed
Sep 8, 2021
| class ::PostsController < ActionController::Base ; end | ||
| cases.each do |(view_method, tag_match)| | ||
| app_file "app/views/posts/#{view_method}.html.erb", "<%= #{view_method} '#{contents}', skip_pipeline: true %>" | ||
| ::PostsController.define_method(:index) { render view_method } |
There was a problem hiding this comment.
Would not this cause a warning since we are defining the same method more than once?
There was a problem hiding this comment.
You are right, I didn't notice it on dev, but it appears in the CI. You can see it with ruby -w bin/test test/application/asset_debugging_test.rb
The query implementation approach is easier for avoid that warning, I am going to push another commit without warnings.
ceritium
force-pushed
the
asset-debugging-template-per-case
branch
from
73fcd46
to
5dc8f97
Compare
|
The red tests seem unrelated. Could you squash commits? |
It avoids the problem when the file checker is not able to detect changes on the files during testing.
ceritium
force-pushed
the
asset-debugging-template-per-case
branch
from
5dc8f97
to
0063fb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It avoids the problem when the file checker is not able to detect changes
on the files during testing.
Summary
railties/test/application/asset_debugging_test.rbare failing from time to time on CI. After some investigations, I discovered that it is caused due howFileUpdateCheckerworks.FileUpdateCheckerrequires 1 second to detect file changes in a file.This PR avoids the problem of creating a new template per case.
Other Information
It is a PR for debugging the issue #43174
Alternative approaches: