Fixed failing tests uninitialized constant ActiveSupport::Dependencies in #432

Closed
wants to merge 1 commit into from

2 participants

@arunagw
Ruby on Rails member

Need this require.

Removed here d89a796

/cc @josevalim

@josevalim
Ruby on Rails member

@arunagw why it is needed? that commit was explicitly removing AS::Dependencies from DescendantsTracker.

@josevalim
Ruby on Rails member

Btw, the tests pass here. :( How can I reproduce the failure?

@arunagw
Ruby on Rails member

rails/railties git:(master)* ruby -Itest -I/Users/arunagw/checkouts/rails/railties/../activesupport/lib test/generators_test.rb jruby-1.6.1
Loaded suite test/generators_test
Started
..........................E...
Finished in 4.306 seconds.

1) Error:
test_rails_root_templates(GeneratorsTest):
NoMethodError: undefined method parents' for #<TestApp::Application:0x7fca4868>
org/jruby/RubyKernel.java:2052:in
send'
/Users/arunagw/checkouts/rails/railties/lib/rails/railtie/configurable.rb:28:in method_missing'
/Users/arunagw/checkouts/rails/railties/lib/rails/generators/named_base.rb:65:in
namespace'
/Users/arunagw/checkouts/rails/railties/lib/rails/generators/named_base.rb:70:in namespaced?'
/Users/arunagw/checkouts/rails/railties/lib/rails/generators/named_base.rb:78:in
class_path'
/Users/arunagw/checkouts/rails/railties/lib/rails/generators/named_base.rb:93:in class_name'
/Users/arunagw/checkouts/rails/railties/lib/rails/generators/named_base.rb:181:in
check_class_collision'
org/jruby/RubyProc.java:268:in `call'

@arunagw
Ruby on Rails member

rails/railties git:(master)* bundle exec rake test ree-1.8.7-2011.03
(in /Users/arunagw/checkouts/rails/railties)
/Users/arunagw/.rvm/rubies/ree-1.8.7-2011.03/bin/ruby -Itest -I/Users/arunagw/checkouts/rails/railties/../activesupport/lib test/application/configuration_test.rb
Loaded suite test/application/configuration_test
Started
EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE
Finished in 2.715791 seconds.

1) Error:
test_Rails.application_is_nil_until_app_is_initialized(ApplicationTests::ConfigurationTest):
ActiveSupport::Testing::RemoteError: caught NameError: uninitialized constant ActiveSupport::Dependencies
/Users/arunagw/checkouts/rails/bundle/ruby/1.8/gems/rake-0.8.7/lib/rake.rb:2503:in const_missing'
/Users/arunagw/checkouts/rails/railties/lib/rails/engine.rb:487
/Users/arunagw/checkouts/rails/railties/lib/rails/initializable.rb:25:in
instance_exec'
/Users/arunagw/checkouts/rails/railties/lib/rails/initializable.rb:25:in run'
/Users/arunagw/checkouts/rails/railties/lib/rails/initializable.rb:50:in
run_initializers'
/Users/arunagw/checkouts/rails/railties/lib/rails/initializable.rb:49:in each'
/Users/arunagw/checkouts/rails/railties/lib/rails/initializable.rb:49:in
run_initializers'
/Users/arunagw/checkouts/rails/railties/lib/rails/application.rb:94:in initialize!'
/Users/arunagw/checkouts/rails/railties/lib/rails/railtie/configurable.rb:28:in
send'
/Users/arunagw/checkouts/rails/railties/lib/rails/railtie/configurable.rb:28:in method_missing'
/Users/arunagw/checkouts/rails/railties/tmp/app/config/environment.rb:5
test/application/configuration_test.rb:44:in
require'
test/application/configuration_test.rb:44:in test_Rails.application_is_nil_until_app_is_initialized'
/Users/arunagw/checkouts/rails/activesupport/lib/active_support/testing/isolation.rb:65:in
run'
/Users/arunagw/checkouts/rails/activesupport/lib/active_support/testing/isolation.rb💯in run_in_isolation'
/Users/arunagw/checkouts/rails/activesupport/lib/active_support/testing/isolation.rb:97:in
fork'
/Users/arunagw/checkouts/rails/activesupport/lib/active_support/testing/isolation.rb:97:in run_in_isolation'
/Users/arunagw/checkouts/rails/activesupport/lib/active_support/testing/isolation.rb:63:in
run'

With REE

@josevalim
Ruby on Rails member

Thanks! This should be fixed here:

c444b0f

@josevalim josevalim closed this May 7, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment