Requires selenium-webdriver 4.0.0 #43270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceritium
force-pushed
the
selenium-webdriver-4
branch
3 times, most recently
from
bfd88e1 to
e905fa9
Compare
rafaelfranca
requested changes
Sep 20, 2021
`selenium-webdriver` added support for Ruby 3.0, but there is only an RC version available right now. Related to rails#43248
ceritium
force-pushed
the
selenium-webdriver-4
branch
from
e905fa9 to
23ea5b0
Compare
Contributor
Author
|
@byroot @rafaelfranca, do you think it's necessary to backport it to Rails 6.1? |
rafaelfranca
added a commit
that referenced
this pull request
Sep 20, 2021
Requires selenium-webdriver 4.0.0 on ruby >= 3.0.0
ceritium
changed the title
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Oct 20, 2021
New Rails 7.0 generator produces a Gemfile with "selenium-webdriver", ">= 4.0.0" to support Ruby 3.0 (rails#43270), and latest webdrivers 5.0.0 requires selenium-webdriver ~ 4.0. https://rubygems.org/gems/webdrivers/versions/5.0.0 It is time to drop selenium-webdriver 3.x support for Rails 7.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It modifies the "rails new" generator to produce a Gemfile with "selenium-webdriver", ">= 4.0.0.rc1"
Other Information
selenium-webdriveradded support for Ruby 3.0, but there is only an RC version available right now.Related to #43248