New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Rails homepage in new tab #43802
Conversation
dc79606
to
ac5ea79
Compare
|
I'm not sure this really adds much. The Rails logo itself is a link to a page that has all those things on it. I'd rather keep this boot screen clean. I could be persuaded of opening in a new window, though. |
ac5ea79
to
1c54488
Compare
|
I understand the goal of keeping it clean, but another plus of adding (at least some of) these links would be the ability to link to a specific version of the docs/guides directly, making it easier for someone new. |
When someone installs it, I would assume its on latest version? I like the simpler version we have right now. If we were to make it useful linking docs to installed version, may be it can be in the link logo has? |
1c54488
to
3e6daa9
Compare
|
Another use case would be for linking to Rails Conductor (when that gets finished) and Mailer Previews in development. There's currently no way for users to easily discover those features easily and this would be a good place for it. I've also updated the page to display links at the top instead for a cleaner look. |
|
Yeah, ultimately I'd love to get all the way to conductor. But it's not going to be in 7.0. So for now, I'm not digging the extra navigation added here. I'll take the target=_new though. |
|
Sounds good, I'll update this PR and we can revisit later. |
3e6daa9
to
b23a1a4
Compare
|
PR is updated @dhh |
|
A little late to the party, but FYI: https://stackoverflow.com/questions/4964130/target-blank-vs-target-new |
|
@lafeber Fixed. Thanks. |
[This tweet](https://twitter.com/bradgessler/status/1630655637096108032) inspired a long conversation on Discord. A lot of it re-hashed the conversation at rails#43802 so I don't want to repeat it. But one takeaway was that not everyone realises the Rails logo is also a link. This PR adds a drop shadow, which I think makes the logo look a bit more clickable at a glance.
With the new boot screen that @dhh just added, it would be very helpful to include links to the Rails Guides, API docs, etc.
By including the Rails version in the Guides and API links, we can take the user directly to the correct version of the Guides and API docs. Also,
target="blank"helps keep their browser tab open so they don't lose it.These links are also helpful to new users for quick access to documentation on their newly created apps.
Screenshot of navigation links
