Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Rails homepage in new tab #43802

Merged
merged 2 commits into from Dec 8, 2021
Merged

Open Rails homepage in new tab #43802

merged 2 commits into from Dec 8, 2021

Conversation

excid3
Copy link
Contributor

@excid3 excid3 commented Dec 8, 2021

With the new boot screen that @dhh just added, it would be very helpful to include links to the Rails Guides, API docs, etc.

By including the Rails version in the Guides and API links, we can take the user directly to the correct version of the Guides and API docs. Also, target="blank" helps keep their browser tab open so they don't lose it.

These links are also helpful to new users for quick access to documentation on their newly created apps.

Screenshot of navigation links
Screen Shot 2021-12-08 at 8 46 49 AM

@dhh
Copy link
Member

dhh commented Dec 8, 2021

I'm not sure this really adds much. The Rails logo itself is a link to a page that has all those things on it. I'd rather keep this boot screen clean. I could be persuaded of opening in a new window, though.

@kylekeesling
Copy link
Contributor

I understand the goal of keeping it clean, but another plus of adding (at least some of) these links would be the ability to link to a specific version of the docs/guides directly, making it easier for someone new.

@onerinas
Copy link

onerinas commented Dec 8, 2021

I understand the goal of keeping it clean, but another plus of adding (at least some of) these links would be the ability to link to a specific version of the docs/guides directly, making it easier for someone new.

When someone installs it, I would assume its on latest version?

I like the simpler version we have right now. If we were to make it useful linking docs to installed version, may be it can be in the link logo has?

@excid3
Copy link
Contributor Author

excid3 commented Dec 8, 2021

Another use case would be for linking to Rails Conductor (when that gets finished) and Mailer Previews in development. There's currently no way for users to easily discover those features easily and this would be a good place for it.

I've also updated the page to display links at the top instead for a cleaner look.

@dhh
Copy link
Member

dhh commented Dec 8, 2021

Yeah, ultimately I'd love to get all the way to conductor. But it's not going to be in 7.0. So for now, I'm not digging the extra navigation added here. I'll take the target=_new though.

@excid3
Copy link
Contributor Author

excid3 commented Dec 8, 2021

Sounds good, I'll update this PR and we can revisit later. 👍

@excid3 excid3 changed the title Helpful links on boot screen Open Rails homepage in new tab Dec 8, 2021
@excid3
Copy link
Contributor Author

excid3 commented Dec 8, 2021

PR is updated @dhh 👍

@dhh dhh merged commit 96c09bc into rails:main Dec 8, 2021
3 of 4 checks passed
rafaelfranca pushed a commit that referenced this pull request Dec 8, 2021
@lafeber
Copy link

lafeber commented Dec 9, 2021

A little late to the party, but FYI: https://stackoverflow.com/questions/4964130/target-blank-vs-target-new

@dhh
Copy link
Member

dhh commented Dec 9, 2021

@lafeber Fixed. Thanks.

@excid3 excid3 deleted the boot-screen-links branch December 9, 2021 13:43
ghiculescu added a commit to ghiculescu/rails that referenced this pull request Mar 1, 2023
[This tweet](https://twitter.com/bradgessler/status/1630655637096108032) inspired a long conversation on Discord. A lot of it re-hashed the conversation at rails#43802 so I don't want to repeat it. But one takeaway was that not everyone realises the Rails logo is also a link. This PR adds a drop shadow, which I think makes the logo look a bit more clickable at a glance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants