Add yarn install into bin/setup when not using importmap #44717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcgibbon
reviewed
Mar 25, 2022
gmcgibbon
approved these changes
Mar 28, 2022
After af7428c the yarn install instructions was dropped from bin/setup. This commmit adds it into the setup script again if the user is not using importmap.
duduribeiro
force-pushed
the
add-js-dependencies-setup-when-not-using-importmaps
branch
from
842f14d
to
155b757
Compare
Thanks a lot @gmcgibbon! psuhed the changes and also squashed the commits. |
duduribeiro
deleted the
add-js-dependencies-setup-when-not-using-importmaps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks 馃憢
IDK if this PR is valid but Want to see a feedback from you.
After af7428c the yarn install
instructions was dropped from bin/setup. I created a project with
Rails 7 and I'm using esbuild and I added it again into my bin/setup
script, since I wanna it updates my dependencies again.
This commit adds yarn install into the setup script again if the user is not using importmap.