Document uses_transaction [ci-skip]
#44956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanhefner
reviewed
Apr 30, 2022
|
Let me know if you want me to squash |
Yes, please! |
Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>
sato11
force-pushed
the
document-uses_transaction
branch
from
f6ecd1e
to
f172628
Compare
|
@jonathanhefner |
jonathanhefner
added a commit
that referenced
this issue
May 3, 2022
Document `uses_transaction` [ci-skip] (cherry picked from commit 74cd04d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Summary
This method has been undocumented, but is named as "a well known public API" in #19251 (comment). Adding documentation had also been encouraged in there but was apparently forgotten. Can we add this so it does not look like private from now on?