Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document uses_transaction [ci-skip] #44956

Merged
merged 1 commit into from May 3, 2022

Conversation

sato11
Copy link
Contributor

@sato11 sato11 commented Apr 25, 2022

Summary

This method has been undocumented, but is named as "a well known public API" in #19251 (comment). Adding documentation had also been encouraged in there but was apparently forgotten. Can we add this so it does not look like private from now on?

@sato11 sato11 requested a review from jonathanhefner May 2, 2022
@sato11
Copy link
Contributor Author

@sato11 sato11 commented May 2, 2022

Let me know if you want me to squash 🙂

@jonathanhefner
Copy link
Member

@jonathanhefner jonathanhefner commented May 2, 2022

@sato11

Let me know if you want me to squash

Yes, please! 😃

Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>
@sato11 sato11 force-pushed the document-uses_transaction branch from f6ecd1e to f172628 Compare May 2, 2022
@sato11
Copy link
Contributor Author

@sato11 sato11 commented May 3, 2022

@jonathanhefner
Did it 👍

@jonathanhefner jonathanhefner merged commit 74cd04d into rails:main May 3, 2022
3 checks passed
@jonathanhefner
Copy link
Member

@jonathanhefner jonathanhefner commented May 3, 2022

Thank you, @sato11! 🙌

Backported to 7-0-stable in 3594d29.

jonathanhefner added a commit that referenced this issue May 3, 2022
Document `uses_transaction` [ci-skip]

(cherry picked from commit 74cd04d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants