Action controller refactor - remove Compatibility module #4497

Merged
merged 15 commits into from Jan 17, 2012

Conversation

Projects
None yet
2 participants

Remove Compatibility module from ActionController, either by cleaning up code that is going to be deprecated in 3.2, or by moving code to their right places inside ActionController modules.

I'm sending a second pull request for 3-2-stable branch deprecating most of the methods inside this module.

Please let me know if something should be improved.
Thanks.

carlosantoniodasilva added some commits Jan 14, 2012

Remove relative url root setting from ENV var
This is already being set by Rails configuration.
Refactor render nothing/text => nil logic, and move to right place
Options :nothing and :text => nil should be handled by
ActionController::Rendering instead.
Remove method missing handling when action is not found, use action m…
…issing instead

Do not create a method_missing method to handle not found actions, use
the action_missing method provided by Rails instead.
Move render_to_body logic to return a spaced string to AC::Rendering
This seems to be required only when calling render :partial with an
empty collection from a controller. This call happens to return no
content, letting the response body empty, which means to Rails that it
should go on and try to find a template to render based on the current
action name, thus failing hard.

Although tests keep all green, we need to check a better way to fix
this.
Remove deprecated default_charset= from AC::Base
This should be set globally as a configuration, using
`config.action_dispatch.default_charset` instead

josevalim added a commit that referenced this pull request Jan 17, 2012

Merge pull request #4497 from carlosantoniodasilva/action-controller-…
…refactor

Action controller refactor - remove Compatibility module

@josevalim josevalim merged commit ba154bd into rails:master Jan 17, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment