Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: fix of name attribute #45013

Merged

Conversation

JohnAnon9771
Copy link
Contributor

@JohnAnon9771 JohnAnon9771 commented May 3, 2022

Summary

Fix of name attribute name to first_name in dynamic finders for correct use of find_by_first_name_and_orders_count method

@rails-bot rails-bot bot added the docs label May 3, 2022
@JohnAnon9771 JohnAnon9771 changed the title fix: name of attribute of name to first_name in dynamic finders doc Doc: fix of name attribute May 3, 2022
@jonathanhefner jonathanhefner merged commit 8bc187d into rails:main May 3, 2022
3 of 4 checks passed
@jonathanhefner
Copy link
Member

@jonathanhefner jonathanhefner commented May 3, 2022

Thank you, @JohnAnon9771! 🎉

Backported to 7-0-stable in fd7dc8f.

jonathanhefner added a commit that referenced this issue May 3, 2022
…rying

Doc: fix of name attribute [ci-skip]
(cherry picked from commit 8bc187d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants