Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Refactor TaggedLogging #4508

Merged
merged 2 commits into from

2 participants

@lest

No description provided.

@josevalim josevalim merged commit 5065d17 into rails:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 18, 2012
  1. @lest

    remove unused requires

    lest authored
  2. @lest
This page is out of date. Refresh to see the latest.
View
3  activesupport/lib/active_support/buffered_logger.rb
@@ -1,8 +1,5 @@
-require 'thread'
-require 'active_support/core_ext/class/attribute_accessors'
require 'active_support/deprecation'
require 'active_support/logger'
-require 'fileutils'
module ActiveSupport
BufferedLogger = ActiveSupport::Deprecation::DeprecatedConstantProxy.new(
View
2  activesupport/lib/active_support/configurable.rb
@@ -1,7 +1,5 @@
require 'active_support/concern'
require 'active_support/ordered_options'
-require 'active_support/core_ext/kernel/singleton_class'
-require 'active_support/core_ext/module/delegation'
require 'active_support/core_ext/array/extract_options'
module ActiveSupport
View
4 activesupport/lib/active_support/tagged_logging.rb
@@ -22,7 +22,7 @@ def tagged(*new_tags)
tags.concat new_tags
yield
ensure
- new_tags.size.times { tags.pop }
+ tags.pop(new_tags.size)
end
def add(severity, message = nil, progname = nil, &block)
@@ -51,7 +51,7 @@ def method_missing(method, *args)
def tags_text
tags = current_tags
if tags.any?
- tags.collect { |tag| "[#{tag}]" }.join(" ") + " "
+ tags.collect { |tag| "[#{tag}] " }.join
end
end
Something went wrong with that request. Please try again.