This commit corrects the Kindle ebook navigation to work on the Kindle Touch.
The commit adapts and incorporates the code from https://github.com/danchoi/docrails_kindle
NOTE: this commit introduces a dependency on nokogiri and kindlerb, but I don't
know the proper place outside this commit (which Gemfile or whatnot) to declare
Generate Kindle ebook with working section navigation
fix frontmatter generation
clear sections/ before regenerating
Oh nice. As the guy who did the original Kindle port, I was really hoping that somebody with a newer Kindle would jump on this.
Thanks for doing the original port @mipearson
@danchoi your patch does not apply cleanly anymore, could you please bring it up-to-date with master, so it get more changes to get merged? Thanks.
Merge remote-tracking branch 'upstream/master'
Fix Kindle doc generation patch
Sorry, I think I messed up my fork of Rails. But the two commits above contain the whole patch.
I can try to submit a new patch if that's cleaner.
Nope, certainly clean!
@fxn could you take a look on this? Let me know if I can help somehow, thanks.
@carlosantoniodasilva thanks for the ping.
A few remarks:
I think it may be a little surprising that a library calls exec, is it needed or could we shell out with system?
The name DocrailsKindle is a little suspicious, docrails is not a project or anything. Could we have a different name for that one? Or could we merge both modules? Makes sense? Where is DocrailsKindle used?
Some commented out code remains, could you please clean that?
@danchoi hey, any news over here?
I'll try to make the fixes that you want this week @fxn. The changes you're asking for are certainly no big deal & I am happy to make them.
Hi. I cleaned up the patches and redid them as a new patch.
@danchoi if you add this patch to your master branch, github will update the pull request.
I added one more commit to clean up the bullet point formatting danchoi@a93ca4c
I committed both of these to my master branch of my fork, but I'm not seeing them show up here.
I think I may have messed things up. Somehow my original fork of rails got deleted (maybe I did it, but I don't remember), and so I made a new fork today and created the these last two commits.
Hm, how strange. @github must be acting a bit weird.
Hey @fxn, this merges cleanly; can we get it in?
@steveklabnik cool thanks for the ping. I am out not, but I'll try to have a look later today.
Is the file docrails_kindle.rb being used?
I think I removed it.
@danchoi as you say this PR does not seem to be sync'ed with the most recent changes. I think it would be better to review the real patch as is today. Would you mind opening a new PR with the last code?
Moved to #8254, closing here.