Skip to content

Remove ActiveSupport::TestCase#pending, use `skip` instead #4575

Merged
merged 1 commit into from Jan 21, 2012

4 participants

@carlosantoniodasilva
Ruby on Rails member

The pending method nowadays works basically delegating to skip, so I believe there is no real need to have it. We should just start using skip directly.

@josevalim josevalim merged commit 1620df7 into rails:master Jan 21, 2012
@jeremy
Ruby on Rails member
jeremy commented May 17, 2012

This needs to be deprecated on 3-2-stable. Otherwise, tests just break when upgrading an app and you have to Google to find out why and how to fix.

@carlosantoniodasilva
Ruby on Rails member

@jeremy ok.

@rafaelfranca are you already working on this, confirm?

@rafaelfranca
Ruby on Rails member

Confirm. I need to discuss it better, but it is almost done.

@carlosantoniodasilva
Ruby on Rails member
@carlosantoniodasilva
Ruby on Rails member

I was reviewing my old list of issues and found this one, and I did the changes in this branch, let me know what you think.

@jeremy
Ruby on Rails member
jeremy commented Nov 17, 2012

👍

@rafaelfranca
Ruby on Rails member

:shipit:

@carlosantoniodasilva carlosantoniodasilva added a commit that referenced this pull request Nov 18, 2012
@carlosantoniodasilva carlosantoniodasilva Revert "Merge pull request #4575 from carlosantoniodasilva/remove-tes…
…t-pending"

This reverts commit 1620df7, reversing
changes made to 2d00032.

Conflicts:
	activesupport/CHANGELOG.md
	activesupport/lib/active_support/test_case.rb
4913984
@carlosantoniodasilva carlosantoniodasilva added a commit that referenced this pull request Nov 18, 2012
@carlosantoniodasilva carlosantoniodasilva Merge branch 'deprecate-pending'
Properly deprecate #pending from AS::TestCase. This has been previously
removed from master, and is now back with a deprecation instead, to avoid
people having tests breaking when upgrading an app.

Please check #4575 for more background.
e21579f
@carlosantoniodasilva
Ruby on Rails member

Done, thanks!

@sgerrand sgerrand pushed a commit to sgerrand/rails that referenced this pull request Nov 2, 2013
@carlosantoniodasilva carlosantoniodasilva Properly deprecate #pending from AS::TestCase 92da512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.