Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix ActiveSupport::Base64.decode64 #4611

Merged
merged 1 commit into from

4 participants

@jviney

No description provided.

@vijaydev vijaydev merged commit 70d81b3 into rails:3-2-stable
@lzap

Is this a typo? What is wrong here? Should be ENCODE not DECODE.

Collaborator

@lzap look at the method name, this is self.decode64 method, therefore it should call decode

Ah it was wrong and now it is correct. Was coming from ApiDoc where it was still incorrect :-) Great. TY.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 23, 2012
  1. @jviney

    The deprecated ActiveSupport::Base64.decode64 method should call ::Ba…

    jviney authored
    …se64.decode64 not ::Base64.encode64
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  activesupport/lib/active_support/base64.rb
View
2  activesupport/lib/active_support/base64.rb
@@ -40,7 +40,7 @@ def self.encode64(value)
def self.decode64(value)
ActiveSupport::Deprecation.warn "ActiveSupport::Base64.decode64 " \
"is deprecated. Use Base64.decode64 instead", caller
- ::Base64.encode64(value)
+ ::Base64.decode64(value)
end
def self.encode64s(value)
Something went wrong with that request. Please try again.