Add Rails.env.local? #46786
Merged
Add Rails.env.local? #46786
+33
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So many checks against Rails.env is whether we're running test or development, so combine into just one.
Now that we have it as a combined predicate for dev + test.
4 tasks
9 tasks
Gerg
added a commit
to cloudfoundry/cloud_controller_ng
that referenced
this pull request
Jan 3, 2024
- Rails introduced `Rails.env.local?` (rails/rails#46786) with a different implementation than what we were using in stagings_controller.rb. The previous implementation (metaprogramming?) was introduced for the `scripts/cf-release/run-local-cc.sh` script, which appears to be non-functional these days. [#3438]
johha
pushed a commit
to cloudfoundry/cloud_controller_ng
that referenced
this pull request
Feb 1, 2024
- Rails introduced `Rails.env.local?` (rails/rails#46786) with a different implementation than what we were using in stagings_controller.rb. The previous implementation (metaprogramming?) was introduced for the `scripts/cf-release/run-local-cc.sh` script, which appears to be non-functional these days. [#3438]
4 tasks
glaszig
added a commit
to glaszig/exception_notification
that referenced
this pull request
Mar 12, 2024
Rails.env.local? is available since 7.1, rails/rails#46786
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So many checks against Rails.env is whether we're running test or development, so combine into just one.
Before:
After: