Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add :password_confirmation as a filtered param by default. #4690

Merged
merged 1 commit into from Jan 26, 2012

Conversation

Projects
None yet
2 participants
Contributor

JDutil commented Jan 26, 2012

Most authentication solutions like Devise and Authlogic use a password confirmation field. I end up adding this to every rails app, and I'm sure plenty of other developers need to as well. Forgetting this could inadvertently leave a password unfiltered during user registration so I think it's a sensible default.

josevalim added a commit that referenced this pull request Jan 26, 2012

Merge pull request #4690 from jdutil/filter_password_confirmation
Add :password_confirmation as a filtered param by default.

@josevalim josevalim merged commit eafa1c4 into rails:master Jan 26, 2012

josevalim added a commit that referenced this pull request Jan 26, 2012

Revert "Merge pull request #4690 from jdutil/filter_password_confirma…
…tion"

This reverts commit eafa1c4, reversing
changes made to f251437.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment