Remove redundant instance variables (@colorize_logging) #4722

Merged
merged 1 commit into from Jan 27, 2012

Projects

None yet

3 participants

@kennyj
Contributor
kennyj commented Jan 27, 2012

The setting for colorize logging is present in two place.

config.colorize_logging

and

ActiveSupport::LogSubscriber.colorize_logging

This duplication is a little difficult to understand.
Because config.colorize_logging is set to nil in default, but ActiveSupport::LogSubscriber.colorize_logging is set to true.

Please see #4708 .

Contributor
kennyj commented Jan 27, 2012

I found this

./railties/guides/source/configuring.textile:* +config.colorize_logging+ specifies whether or not to use ANSI color codes when logging information. Defaults to true.
@tenderlove tenderlove merged commit 578c94a into rails:master Jan 27, 2012
@carlosantoniodasilva

I think it should read "default".

Sorry, @vijaydev fixed in a8da5d8.

Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment