New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance has_secure_password to also generate a password_salt method #47490
Merged
jonathanhefner
merged 1 commit into
rails:main
from
lazaronixon:has_secure_password_salt
Mar 9, 2023
Merged
Enhance has_secure_password to also generate a password_salt method #47490
jonathanhefner
merged 1 commit into
rails:main
from
lazaronixon:has_secure_password_salt
Mar 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazaronixon
force-pushed
the
has_secure_password_salt
branch
from
February 24, 2023 04:42
4cf3d2d
to
d6e5d1d
Compare
lazaronixon
force-pushed
the
has_secure_password_salt
branch
2 times, most recently
from
March 8, 2023 05:37
ce659be
to
3633390
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this! 😀
Also, what do you think about updating the example in the documentation for rails/activerecord/lib/active_record/token_for.rb Lines 68 to 71 in 3dd5d49
|
lazaronixon
force-pushed
the
has_secure_password_salt
branch
from
March 9, 2023 04:00
3633390
to
e1db01d
Compare
lazaronixon
force-pushed
the
has_secure_password_salt
branch
3 times, most recently
from
March 9, 2023 04:54
cf86672
to
59f3316
Compare
lazaronixon
force-pushed
the
has_secure_password_salt
branch
3 times, most recently
from
March 9, 2023 19:34
9307434
to
b842755
Compare
lazaronixon
force-pushed
the
has_secure_password_salt
branch
from
March 9, 2023 19:45
b842755
to
ebe9e57
Compare
jonathanhefner
approved these changes
Mar 9, 2023
Thank you, @lazaronixon! 🧂 |
paracycle
added a commit
to Shopify/tapioca
that referenced
this pull request
Jul 19, 2023
Added in Rails here: rails/rails#47490
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
As mentioned here there's an additional task to be done in order to simplify the token generation for password hashes.
Before:
After: