Remove slash from favicon_link_tag method attribute #4803

Merged
merged 1 commit into from Jan 31, 2012

Conversation

Projects
None yet
2 participants
Contributor

lucascaton commented Jan 31, 2012

HTML code is not shown here, then I'll paste the code in the gist: https://gist.github.com/1707977

tenderlove added a commit that referenced this pull request Jan 31, 2012

Merge pull request #4803 from lucascaton/master
Remove slash from favicon_link_tag method attribute

@tenderlove tenderlove merged commit bb842e8 into rails:master Jan 31, 2012

spastorino added a commit that referenced this pull request Feb 20, 2013

Revert "Merge pull request #4803 from lucascaton/master"
This reverts commit bb842e8, reversing
changes made to 40c287c.
This was causing issues in one of our apps we just upgraded.
ActionController::RoutingError: No route matches [GET]
"/images/favicon.ico"
favicon_link_tag now returns '/images/favicon.ico' and in 3.2 returned
'/favicon.ico'
Browsers by default look for favicon.ico in the root directory

Conflicts:
	actionpack/CHANGELOG.md
	actionpack/lib/action_view/helpers/asset_tag_helper.rb

spastorino added a commit that referenced this pull request Feb 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment