Default message serializer to :json_allow_marshal
#48170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, `config.load_defaults 7.1` would cause old messages (or messages from older apps) to become unreadable, and developers were encouraged to manually set `config.active_support.message_serializer = :json_allow_marshal` in order to prevent this. This commit changes the default message serializer set by `config.load_defaults 7.1` from `:json` to `:json_allow_marshal` so that upgraded apps can continue to read old messages without additional configuration. The intention is to eventually change the default to `:json` (with no `Marshal` fallback) in Rails 7.2, after some time has passed with apps generating JSON-serialized messages. Apps can opt in to JSON-only serialization before Rails 7.2 by manually setting `config.active_support.message_serializer = :json`. Fixes rails#48118.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
config.load_defaults 7.1would cause old messages (or messages from older apps) to become unreadable, and developers were encouraged to manually setconfig.active_support.message_serializer = :json_allow_marshalin order to prevent this.This commit changes the default message serializer set by
config.load_defaults 7.1from:jsonto:json_allow_marshalso that upgraded apps can continue to read old messages without additional configuration.The intention is to eventually change the default to
:json(with noMarshalfallback) in Rails 7.2, after some time has passed with apps generating JSON-serialized messages.Apps can opt in to JSON-only serialization before Rails 7.2 by manually setting
config.active_support.message_serializer = :json.Fixes #48118.