Issue #4819 'uninitialized constant ActiveRecord::Deprecation in Rails3.2.1' #4867

Closed
wants to merge 321 commits into from
@densya203

in /active_record/connection_adapters/abstract/schema_statements.rb line 429

if table_exists?(si_table)
  ActiveRecord::Deprecation.warn "Usage of the schema table `#{si_table}` is deprecated. Please switch to using `schema_migrations` table"

  old_version = select_value("SELECT version FROM #{quote_table_name(si_table)}").to_i
  assume_migrated_upto_version(old_version)
  drop_table(si_table)
end

It called 'ActiveRecord::Deprecation.warn',
It is typo of 'ActiveSupport::Deprecation.warn'.

Since MyApp was so old (ver1.2.6),
it had schema_info table, so I came accross this typo.

josevalim and others added some commits Dec 28, 2011
@josevalim josevalim Merge pull request #4210 from tapajos/patch-1
Fix #4208
d547761
@tapajos tapajos Remove empty line. 7767159
@fxn fxn Merge pull request #4217 from tapajos/patch-2
Remove empty line
40cab62
@bensie bensie Further simplify singleton_class checking in class_attribute 520918a
@spastorino spastorino Bump to rack 1.4.0 2004a13
@spastorino spastorino Add CHANGELOG entry a0fd9fb
@tenderlove tenderlove Merge pull request #4196 from gazay/3-2-stable-marshalling
3.2 stable marshalling
df37018
@jonleighton jonleighton Revert "Further simplify singleton_class checking in class_attribute"
This reverts commit 520918aad9b84eee807eb42fcb32f57c152d50e0.

Reason: build failure
bbafe73
@fxn fxn app code in general wants Time.current, not Time.now 7a80ac0
@tenderlove tenderlove last named route wins. fixes #4164
This differs from route recognition where first recognized route wins.
This will not be supported in Rails 4.0 so that route recognition and
generation rules are consistent.
50af25b
@tenderlove tenderlove Revert "Merge pull request #4196 from gazay/3-2-stable-marshalling"
This reverts commit df3701872d6c97ff49943aea30761b47e60fa9fe, reversing
changes made to a0fd9fb01730af12d66a27b5665cc010bd3b90b4.
80f2eeb
@tenderlove tenderlove Merge pull request #4216 from edgecase/master_fix_reorder_with_limite…
…d_ids

allow reorder to affect eager loading correctly
f423bdc
@gazay gazay Backward compatibility with 3.1 cache storing b815676
@ugisozols ugisozols Remove unnecessary comma. bea4f9a
@joliss joliss Document that index names are made up of all columns, not just the fi…
…rst.

index_name has been using the following expression

    "index_#{table_name}_on_#{Array.wrap(options[:column]) * '_and_'}"

since at least 2006 (bc7f2315), and that's how they come out in my DB.

Please check that this is correct before merging into master, perhaps
I'm misunderstanding the section I changed.
d8a43e2
@kevmoo kevmoo Documented about using :path option for resources 2e533e3
@fuzzyalej fuzzyalej Fixed formatting of code examples in form_tag_helper.rb 5f57d2a
@vijaydev vijaydev revise some doc changes 63c6fee
@tenderlove tenderlove fixing typo. Thanks Vijay! 766eda3
@lest lest refactor Range#include? to handle ranges with floats
Conflicts:

	activesupport/lib/active_support/core_ext/range/include_range.rb
71f59b7
@fxn fxn adds a comments that clarifies why Range#include? chooses the compari…
…son operator
0814e74
@tenderlove tenderlove Merge pull request #4227 from gazay/3-2-stable-marshalling
3 2 stable marshalling
f12d904
@fuzzyalej fuzzyalej Fixed documentation error in code examples from form_tag_helper.rb 8be9d92
@vijaydev vijaydev fix a couple of formatting issues ba19837
@vijaydev vijaydev remove wiki link 0a048f3
@sumbach sumbach SCSS processor is provided by the sass gem 95a83cc
@sumbach sumbach Minor readability improvements 003d0ff
@vijaydev vijaydev DRY up guides index page
Use the list of guides available in documents.yaml to fill in the
menu in the index page instead of duplicating the list again. Also,
remove WIP guides from the menu.
6e9cd38
@lest lest deprecate ActiveSupport::Base64
extend and define ::Base64 if needed
5f09414
@fxn fxn Merge pull request #4267 from lest/3-2-deprecate-activesupport-base64
deprecate ActiveSupport::Base64
7bdfbac
@lest lest fix base64 requires 4f440a3
@fxn fxn Merge pull request #4268 from lest/3-2-deprecate-activesupport-base64
fix base64 requires
e369c4e
@lest lest use pg 0.11.0 under ruby 1.8.7 0b5cda7
@josevalim josevalim Merge pull request #4273 from lest/fix-pg-version
use pg 0.11.0 under ruby 1.8.7
2535898
@spastorino spastorino Deprecate Rails::Plugin in favor of gems 853de2b
@lest lest deprecate AS::Base64 methods without DeprecatedConstantProxy 1fc53df
@josevalim josevalim Merge pull request #4275 from lest/3-2-deprecate-activesupport-base64
deprecate AS::Base64 methods without DeprecatedConstantProxy
c032ff6
@spastorino spastorino Merge pull request #4278 from kennyj/fix_rdoc_generating_problem
Use -e option instead of -c option (rake rdoc task).
ca24ee7
@tenderlove tenderlove Merge pull request #4279 from lest/fix-log
do not rewrite log during application bootstrap
eafdf6c
@spastorino spastorino Add font_path helper method 0d7d3a6
@bogdan bogdan AS::Callbacks: improve __define_runner perfomance 9f8f4c2
@bogdan bogdan AS::Callbacks: improved __define_runner performance 4e8286f
@bogdan bogdan Refactor AS::Callbacks
Extracted `__reset_runner` from `__define_runner`
And call it in proper places
5b8d270
@bogdan bogdan AS::Callbacks: remove __define_runner 40c8aa7
@josevalim josevalim Override respond_to? since we are also overriding method_missing. d38dac8
@josevalim josevalim Merge pull request #4280 from lest/3-2-backport-callbacks
backport changes in AS::Callbacks
124536e
@spastorino spastorino Pass extensions to javascript_path and stylesheet_path helpers. Close…
…s #3417
8c129f1
@lest lest add CHANGELOG entry for AS::Base64 deprecation 337ac05
@spastorino spastorino Merge pull request #4281 from lest/3-2-changelog
add CHANGELOG entry for AS::Base64 deprecation
caa6cde
@kevmoo

Where is the design discussion around this decision? I'm not arguing against it at all, but I'd love to understand why this was done.

Thanks

Ruby on Rails member

vendor/plugins/* were on their way out with Rails 3.0, moving to gems instead. This is their last hurrah.

tenderlove and others added some commits Jan 3, 2012
@tenderlove tenderlove Merge pull request #4283 from lest/fix-singleton-checking
use correct variant of checking whether class is a singleton
c4a29de
@tenderlove tenderlove Revert "Named Routes shouldn't override existing ones (currently rout…
…e recognition goes with the earliest match, named routes use the latest match)"

This reverts commit 71d769e3b58cb56b4b1d5143936c65be8b27c490.
e912211
@tenderlove tenderlove When generating routes, the last defined named route wins. This is in
contrast to route recognition where the first recognized route wins.
This behavior will not exist in Rails 4.0.

See:

  rails/rails#4245
  rails/rails#4164
63f7a61
@kennyj kennyj Fix GH #4285. Remove options when we record calling creat_table 6012970
@josevalim josevalim Merge pull request #4288 from kennyj/fix_4285-2
(3-2-stable) Fix GH #4285. Remove options when we record calling create_table
a10f309
@imkmf imkmf Final grammar checkup on 3.2 release notes. 6bcc1b8
@vijaydev vijaydev updates to 3.2 release notes bc36613
@ffmike ffmike General editing pass over assets pipeline guide 20a4258
@elpic elpic improve doc in number helper options 00a27c5
@vijaydev vijaydev copy edits 4b2b595
@spastorino spastorino Revert "use pg 0.11.0 under ruby 1.8.7"
There's a new pg release, no need for this anymore
This reverts commit 0b5cda73e2f5d29420afb41d5ed6908baf624934.
3fb32cf
@spastorino spastorino Use sass-rails 3.2.3 f8df37b
@tenderlove tenderlove Merge pull request #4282 from edgecase/order_after_reorder
correctly handle order calls after a reorder
d22592a
@jeremy jeremy Clarify vendor/plugins deprecation warning d9e0c4a
@jeremy jeremy Add release notes URL to vendor/plugins deprecation warning. Update C…
…HANGELOG.
49a1017
@josevalim josevalim Revert "AS::Callbacks: remove __define_runner"
Runners are used internally.

This reverts commit 40c8aa706adbb60ff9d289016fb9020d48969fea.
0b24dc9
@spastorino spastorino Bump to rc2 d268ef2
@kuroda kuroda Infer currency negative format from positive one.
When a locale file sets the format of the positive
currency value as '%n %u', the default negative
currency format should be '-%n %u'.

Cherry-picked from master (6724c8c8)
22f901c
@tenderlove tenderlove Merge pull request #4311 from kuroda/3-2-negative_format
Infer currency negative format from positive one. (3-2-stable)
867a792
@spastorino spastorino Depend on coffee-rails 3.2.1 6005736
@kennyj kennyj Don't fork a process when assets:precompile:nondigest is invoked in a…
…ssets:precompile:all. Improve GH #3694.
2056744
@josevalim josevalim Merge pull request #4352 from kennyj/improve_3694-2
[3-2-stable] Don't fork a process when assets:precompile:nondigest is invoked in assets:precompile:all.
a579d4b
@drogus drogus Add ORIGINAL_FULLPATH to env
This behaves similarly to REQUEST_URI, but
we need to implement it on our own because
REQUEST_URI is not reliable.

Note that since PATH_INFO does not contain
information about trailing question mark,
this is not 100% accurate, for example
`/foo?` will result in `/foo` in ORIGINAL_FULLPATH
63305da
@drogus drogus Add original_fullpath and original_url methods to Request 79b12a0
@drogus drogus Fix http digest authentication with trailing '/' or '?' (fixes #4038 …
…and #3228)
d65b766
@spastorino spastorino Rails initialization with initialize_on_precompile = false should set…
… assets_dir
3375a09
@spastorino spastorino Add CHANGELOG entry 6f48fb3
@spastorino spastorino Remove dead code bda0ae7
@josevalim josevalim Remove duplicated test line which was causing Ci failures on 1.8.7. ae14b71
@spastorino spastorino Add "What to update in your apps" section to the release notes guide
We should keep this up to date and the current version is probably wrong
and/or incomplete. HELP!!!
03f6275
@tenderlove tenderlove deprecate the subdirectories parameter to `migrations`
Conflicts:

	activerecord/lib/active_record/migration.rb
5e04884
dhh and others added some commits Jan 20, 2012
@dhh dhh Preparing for 3.2.0 release f36dcaf
@jonleighton jonleighton Fix another race condition.
From 2c667f69aa2daac5ee6c29ca9679616e2a71532a.

Thanks @pwnall for the heads-up.

Conflicts:

	activerecord/lib/active_record/core.rb
fab664a
Jonathan Roes and others added some commits Jan 20, 2012
Jonathan Roes document `:raise` option support for several helpers [ci skip] c701358
@kennyj kennyj Fix GH #4580. Rails 3.2: uninitialized constant ActiveSupport::Tagged…
…Logging::ERROR
caf7856
@josevalim josevalim Merge pull request #4582 from kennyj/fix_4580
Fix  GH #4580. Rails 3.2: uninitialized constant ActiveSupport::TaggedLogging::ERROR
a720e34
@waseem waseem Remove deprecation warning from console output when running
activesupport tests.
892c670
@josevalim josevalim Merge pull request #4586 from waseem/assert_with_no_deprecation_warnings
Assert with no deprecation warnings activesupport tests.
d5dde37
@jviney jviney Fix `$rails_rake_task` global variable warning without replacing the …
…value of $rails_rake_task if it is already set.

Fixes #4591.

Signed-off-by: José Valim <jose.valim@gmail.com>
9ab2904
@carlosantoniodasilva carlosantoniodasilva Add missing require to Array#wrap in generators action methods d246da1
@iHiD iHiD Allow form.select to accept ranges. c6dcc35
@josevalim josevalim Merge pull request #4604 from ihid/3-2-stable
3-2-stable: Fixed regression - unable to use a range as choices for form.select.
334e5ca
@josevalim josevalim Support decimal{1,2} and decimal{1-2} and decimal{1.2} so it works fi…
…ne with bash, zsh, etc, closes #4602
ede01ce
@jviney jviney The deprecated ActiveSupport::Base64.decode64 method should call ::Ba…
…se64.decode64 not ::Base64.encode64
44319ef
@vijaydev vijaydev Merge pull request #4611 from jviney/3-2-stable
Fix ActiveSupport::Base64.decode64
70d81b3
@vijaydev vijaydev test base64 encode and decode 912f144
@josevalim josevalim Merge pull request #4601 from carlosantoniodasilva/patch-1
Add missing require to Array#wrap in generators action methods
b840461
@tenderlove tenderlove Added custom regexps to ASTs that have literal nodes on either side of
symbol nodes.  Fixes #4585
3913b51
@tenderlove tenderlove work against 1-0-stable until a new journey is released 1a56a76
@cgriego

Not sure if this is a work in progress but just in case, fyi, my app won't boot after this commit.

rails-1a56a761530e/actionpack/lib/action_dispatch/routing/route_set.rb:268:in `to_proc': undefined method `literal?' for #<Journey::Nodes::Slash:0x10be0f400 @memo=nil, @left="/"> (NoMethodError)
    from rails-1a56a761530e/actionpack/lib/action_dispatch/routing/route_set.rb:268:in `find_all'
    from journey-1.0.0/lib/journey/visitors.rb:48:in `call'
    from journey-1.0.0/lib/journey/visitors.rb:48:in `visit'
    from journey-1.0.0/lib/journey/visitors.rb:15:in `binary'
    from journey-1.0.0/lib/journey/visitors.rb:18:in `visit_CAT'
    from journey-1.0.0/lib/journey/visitors.rb:11:in `send'
    from journey-1.0.0/lib/journey/visitors.rb:11:in `visit'
    from journey-1.0.0/lib/journey/visitors.rb:47:in `visit'
    from journey-1.0.0/lib/journey/visitors.rb:6:in `accept'
    from journey-1.0.0/lib/journey/nodes/node.rb:16:in `each'
    from rails-1a56a761530e/actionpack/lib/action_dispatch/routing/route_set.rb:381:in `find_all'
    from rails-1a56a761530e/actionpack/lib/action_dispatch/routing/route_set.rb:381:in `build_path'
    from rails-1a56a761530e/actionpack/lib/action_dispatch/routing/route_set.rb:355:in `add_route'
    from rails-1a56a761530e/actionpack/lib/action_dispatch/routing/mapper.rb:1304:in `add_route'
    from rails-1a56a761530e/actionpack/lib/action_dispatch/routing/mapper.rb:1282:in `decomposed_match'
    from rails-1a56a761530e/actionpack/lib/action_dispatch/routing/mapper.rb:1268:in `match'
    from rails-1a56a761530e/actionpack/lib/action_dispatch/routing/mapper.rb:1268:in `each'
    from rails-1a56a761530e/actionpack/lib/action_dispatch/routing/mapper.rb:1268:in `match'
    from rails-1a56a761530e/actionpack/lib/action_dispatch/routing/mapper.rb:411:in `mount'
    from rails-1a56a761530e/actionpack/lib/sprockets/bootstrap.rb:28:in `run'
    from rails-1a56a761530e/actionpack/lib/action_dispatch/routing/route_set.rb:272:in `instance_exec'
    from rails-1a56a761530e/actionpack/lib/action_dispatch/routing/route_set.rb:272:in `eval_block'
    from rails-1a56a761530e/actionpack/lib/action_dispatch/routing/route_set.rb:287:in `clear!'
    from rails-1a56a761530e/actionpack/lib/action_dispatch/routing/route_set.rb:287:in `each'
    from rails-1a56a761530e/actionpack/lib/action_dispatch/routing/route_set.rb:287:in `clear!'
    from rails-1a56a761530e/railties/lib/rails/application/routes_reloader.rb:35:in `clear!'
    from rails-1a56a761530e/railties/lib/rails/application/routes_reloader.rb:33:in `each'
    from rails-1a56a761530e/railties/lib/rails/application/routes_reloader.rb:33:in `clear!'
    from rails-1a56a761530e/railties/lib/rails/application/routes_reloader.rb:15:in `reload!'
    from rails-1a56a761530e/railties/lib/rails/application/routes_reloader.rb:26:in `updater'
    from rails-1a56a761530e/activesupport/lib/active_support/file_update_checker.rb:78:in `call'
    from rails-1a56a761530e/activesupport/lib/active_support/file_update_checker.rb:78:in `execute'
    from rails-1a56a761530e/railties/lib/rails/application/routes_reloader.rb:27:in `updater'
    from rails-1a56a761530e/railties/lib/rails/application/routes_reloader.rb:9:in `execute_if_updated'
    from rails-1a56a761530e/railties/lib/rails/application/finisher.rb:66
    from rails-1a56a761530e/railties/lib/rails/initializable.rb:30:in `instance_exec'
    from rails-1a56a761530e/railties/lib/rails/initializable.rb:30:in `run'
    from rails-1a56a761530e/railties/lib/rails/initializable.rb:55:in `run_initializers'
    from rails-1a56a761530e/railties/lib/rails/initializable.rb:54:in `each'
    from rails-1a56a761530e/railties/lib/rails/initializable.rb:54:in `run_initializers'
    from rails-1a56a761530e/railties/lib/rails/application.rb:136:in `initialize!'
Ruby on Rails member

@cgriego you have to use journey 1-0-stable branch or wait for a new release

Thanks @rafaelfranca, maybe I'm wrong but shouldn't the Gemfile generator reflect that if people generate with the --edge option?

Ruby on Rails member

I don't know. Maybe @tenderlove have an answer

kennyj and others added some commits Jan 22, 2012
@kennyj kennyj Fix GH #4344. A defined callback in extended module is called too.
Conflicts:

	activesupport/test/callbacks_test.rb
dc826f9
@indrekj indrekj Add failing test for date_select
date_select does not work when day is discarded, include blank option is
enabled and struct date itself is nil.
d4cfc4c
@indrekj indrekj Fix date_select nil and blank and order case d92b5fe
@joevandyk joevandyk datetime_select should work with -/+ infinity dates 59a408e
@rafaelfranca rafaelfranca Fix date_select with discard_month and discard_year options
Closes #4553 and #4633
c4b7ca0
@tenderlove tenderlove Merge pull request #4514 from brainopia/update_timezone_offets
Update time zone offset information
e0fe62b
@josevalim josevalim Merge pull request #4641 from rafaelfranca/date_select-fix-3-2
date_select fixes [3-2-stable]
5a66d33
@rafaelfranca rafaelfranca Remove unused variables to avoid warnings 3cd28e2
@josevalim josevalim Merge pull request #4643 from rafaelfranca/3-2-stable
Remove unused variables to avoid warnings
dc81d00
@tenderlove tenderlove Merge pull request #4639 from joevandyk/datetime-infinity-select-fix
datetime_select fix for dates of -infinity and +infinity
1d67f1a
@pwim pwim allow requiring of 'active_model/naming'
Requiring 'active_model/naming' will raise an uninitialized constant
ActiveSupport::Deprecation exception because the module core extension
doesn't require 'active_support/deprecation'. This require cannot be
added to the core extension because of circular dependency issues.
75d58fe
@josevalim josevalim Merge pull request #4654 from pwim/explicit-deprecation-require
Explicit deprecation require
9e9e17a
@pwim pwim Test for unicode path support
This is currently broken due to a bug in journey.
22980e0
@lzap

Is this a typo? What is wrong here? Should be ENCODE not DECODE.

Ruby on Rails member

@lzap look at the method name, this is self.decode64 method, therefore it should call decode

Ah it was wrong and now it is correct. Was coming from ApiDoc where it was still incorrect :-) Great. TY.

tenderlove and others added some commits Jan 25, 2012
@tenderlove tenderlove Merge pull request #4658 from pwim/unicode-paths
Test for unicode path support
11e88a4
@damln damln example bracket error fd9d394
@rohit rohit remove extra 'the' a267090
@carlosantoniodasilva carlosantoniodasilva Fix custom validation methods section in AR validations and callbacks…
… guide

The methods validate_on_create and validate_on_update are not available
anymore in Rails, this removes them from the guide and adds an example
on how to use validate with the :on option.
6a85c45
@carlosantoniodasilva carlosantoniodasilva Change ActiveRecord::Errors to ActiveModel::Errors in guides
Use ActiveModel::Errors in inflection example docs as well.

Also fixes wrong information and link to locale file related to
Errors#full_messages in I18n guide.
eb171fa
@carlosantoniodasilva carlosantoniodasilva Improve field error proc example in validations guide 79a0488
@carlosantoniodasilva carlosantoniodasilva Fix callbacks order for destroying an object in validations guide
Also add around save to creating/updating callbacks order, and fix save
example with no validation
2d73f70
@lunks lunks Duping log handler. fixes #4668 c9cd0eb
@vijaydev vijaydev Merge pull request #4673 from carlosantoniodasilva/validation-guides-…
…update-3-2

Validation guides update 3 2
b023921
@tenderlove tenderlove Merge pull request #4675 from lunks/3-2-stable
Duping log handler on buffered logger silencer.
1a93eaa
@lest lest call to_s on value passed to table_name=
Signed-off-by: José Valim <jose.valim@gmail.com>
36d7af3
@brainopia brainopia Fix contributing guide to reflect preferred position on indentation 3a087b8
@fxn fxn disable automatic explain if there is no logger [closes #4671] 2483460
@fxn fxn registers 2483460 in the CHANGELOG 2809375
@rafaelfranca rafaelfranca Remove extra attributes from HABTM join tables in AR tests
HABTM Join tables should not have extra attributes

When extra attributes is needed in HABTM join tables is better to use
`has_many :through` association.

Fix #4653
06dcd9c
@tenderlove tenderlove global variables may not be set depending on the match. fixes #4703 7ba3ecc
@tenderlove tenderlove Merge pull request #4696 from rafaelfranca/issue-4653
Remove extra attributes from HABTM join tables in AR tests
5ac5acd
@tenderlove tenderlove bumping journey to 1.0.1 70cbb1c
@atambo atambo safe_constantize should handle wrong constant name NameErrors Fixes #…
…4710

Signed-off-by: José Valim <jose.valim@gmail.com>
6c367a0
@josevalim josevalim Revert usage of safe constantize
Signed-off-by: José Valim <jose.valim@gmail.com>
c134f24
@fxn fxn CHANGELOG revision for v3.2.1 97e8d1d
@fxn fxn updating RAILS_VERSION 67b8fbc
@fxn fxn fixes whitespace in CHANGELOG entries 8e6ef37
@jonleighton jonleighton Merge pull request #4715 from pwim/find-create-multi-args
Fix regression from Rails 3.1
1c5bd8a
Tadas Tamošauskas check_box helper with :disabled => true generates disabled hidden fie…
…ld. fixes #1953
19be5ea
@dmathieu dmathieu don't set the hidden checkbox value if it's nil defb751
@josevalim josevalim Merge check box fixes from remote-tracking branch 'cantonio/checkbox-…
…hidden-backport' into 3-2-stable
2e5ec3b
@dhh dhh Revert "Fix expanding cache key for single element arrays"
This reverts commit abe915f23777efe10f17d611bf5718ca855a0704.

This broke all existing keys and it's wrong anyway. The array is just there as a convenience option for building the string. It's intentional that [ "stuff"] and "stuff" generates the same key.
66b445c
@dhh dhh Inline the prefix assignment so it doesnt look so daft f78cb55
@vijaydev vijaydev fix typo [ci skip] 766e12a
@fxn fxn query cache instrumentation should included the bindings in the paylo…
…ad [closes #4750]
4137905
@bsodmike bsodmike clarification to prevent confusing newbies; Passenger/Unicorn are app…
… servers, Apache/Nginx are the web servers along with thin a la Heroku etc.
93306be
@jonleighton jonleighton Merge pull request #4763 from kennyj/fix_4754
[MySQL] Fix GH #4754. Remove double-quote characters around PK when using sql_mode=ANSI_QUOTES
c472843
@jonleighton jonleighton Add workaround and deprecation if the inherited hook is not executed.…
… Closes #4757.
0bfc504
@jonleighton jonleighton Allow writing unknown attributes, but with a deprecation warning. Clo…
…ses #4583.
b2955ed
@lest lest fix assets test cfea673
@josevalim josevalim Merge pull request #4786 from lest/patch-2
fix assets test in 3-2-stable
175cdd1
@kennyj kennyj Fix GH #4760. A Block was not evaluated. 91700bf
@marten marten Fix use of Deprecation without requiring active_support/deprecation i…
…n ActiveSupport::Concern
cb46423
@marten marten Fix use of Deprecation without requiring active_support/deprecation i…
…n ActiveSupport::Concern in Base64
563be40
@marten marten Fix use of Deprecation without requiring active_support/deprecation i…
…n message verifier
f3e1b21
@marten marten Fix use of Deprecation without requiring active_support/deprecation i…
…n whiny nil
2380a2d
@josevalim josevalim Merge pull request #4790 from marten/fix-require-deprecation-in-activ…
…esupport

Fix Deprecation usage in ActiveSupport when requiring only parts of AS
7beb5a7
@jonleighton jonleighton Merge pull request #4783 from gregolsen/ids_reader_fix
ids_reader method fixed, test added to has_many association (for PostgreSQL)
85c724d
@josevalim josevalim Merge pull request #4793 from kennyj/fix_4760
[3-2-stable] Fix GH #4760. A Block was not evaluated.
bd93ba5
@tenderlove tenderlove Merge pull request #4779 from bsodmike/bsodmike-3-2-stable
Update comment in Gemfile re Unicorn (minor clarification)
60cb7d6
@tenderlove tenderlove Merge pull request #4735 from arton/master
Re-launch assets:precompile task using original $0 if $0 is batch file so it works on Windows
81f14a5
@jonleighton jonleighton Improve deprecation message e1de540
@rafaelfranca rafaelfranca Fix broken tests added by 85c724d59 f532cd1
@spastorino spastorino Merge pull request #4811 from rafaelfranca/3-2-stable-fix
Fix broken build in 3-2-stable branch
1444ec6
@kennyj kennyj Fix GH #4749. Remove branch options, because edge is not 3-2-stable. c8c8439
@carlosantoniodasilva carlosantoniodasilva Generate strict validation error messages with attribute name
Backported from master.
91f8cf2
@spastorino spastorino Merge pull request #4815 from kennyj/fix_4749
Fix GH #4749. Remove branch options, because edge is not 3-2-stable.
21735d2
@josevalim josevalim Merge pull request #4822 from carlosantoniodasilva/strict-validation-3-2
Generate strict validation error messages with attribute name (3-2-stable)
0696a51
@sikachu sikachu Fix plugin_new test failure from c8c84397
`plugin_new` generator doesn't generate `sass-rails` in the Gemfile, so
you can't check for that.
b673ca6
@josevalim josevalim Merge pull request #4827 from sikachu/3-2-stable-fix-plugin-new
Fix plugin_new test failure from c8c84397
780bf52
@jonleighton jonleighton Merge pull request #4543 from jdelStrother/find_or_init
Don't instantiate two objects in collection proxy / find_or_instantiate_by
42dab64
@tenderlove tenderlove Merge pull request #4809 from cfeist/feist-sqlite-binary-corruption
Fix for SQLite binary data corrupter (to master branch)
4ca633e
@densya203 densya203 Fix Issue #4819
'uninitialized constant ActiveRecord::Deprecation in Rails3.2.1'

Just a typo of 'ActiveSupport::...'
daa2665
@kennyj

Hi! @skult Should you send pull request to 3-2-stable?

@arunagw
Ruby on Rails member

Closing this as #4868 is new one!

@arunagw arunagw closed this Feb 3, 2012
@densya203

@kennyj sorry, I made mistake and @arunagw helped me!

@kennyj

@skult No problem :-)

p.s. I'm living in Osaka.

@adsummos

this is triggering a deprecation warning for associations when using the assignment operator (record.association_name = [records])

+1

+3 should we ignore these warning on associations or handle them somehow differently?

@giner

You are crazy guys! You haven't even mentioned such an important change on the changelog!
I have spent three days to solve a problem with Redmine upgrade!
Have a look: http://www.redmine.org/issues/12501

Ruby on Rails member

@giner Please feel free to send a pull request with a changelog entry if that's missing, we're trying to ensure nothing goes without a changelog now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment