New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hstore parser/generator fixes #4896

Merged
merged 7 commits into from Feb 11, 2012

Conversation

Projects
None yet
3 participants
@joelhoffman

joelhoffman commented Feb 5, 2012

Thanks for adding the hstore support, this is great. It's missing a couple of cases though and doesn't quite match the postgres docs, for example "Double-quote keys and values that include whitespace, commas, =s or >s" and "A value (but not a key) can be an SQL NULL." Here are some additional tests (some examples copied from the hstore distribution tests) and code that I think is correct. I previously contributed a version of it to https://github.com/softa/activerecord-postgres-hstore .

@joelhoffman

This comment has been minimized.

Show comment
Hide comment
@joelhoffman

joelhoffman Feb 5, 2012

The parser here is a bit slow due to accepting anything postgres will accept instead of just what postgres "currently" (as the 8.4 but not 9.1 docs say) emits. Not sure if that's necessary.

joelhoffman commented Feb 5, 2012

The parser here is a bit slow due to accepting anything postgres will accept instead of just what postgres "currently" (as the 8.4 but not 9.1 docs say) emits. Not sure if that's necessary.

@tenderlove

This comment has been minimized.

Show comment
Hide comment
@tenderlove

tenderlove Feb 11, 2012

Member

I merged this to master, so I'm closing the PR. Thanks!

Member

tenderlove commented Feb 11, 2012

I merged this to master, so I'm closing the PR. Thanks!

@tenderlove tenderlove closed this Feb 11, 2012

@tenderlove tenderlove merged commit 2dd0178 into rails:master Feb 11, 2012

@kashif

This comment has been minimized.

Show comment
Hide comment
@kashif

kashif Mar 11, 2012

Just a quick question about this. I dont see where the code is calling CREATE EXTENSION hstore; on the ActiveRecord::Base.connection to add support for hstore data types in the Postgres DB. Any insight would be great!

kashif commented Mar 11, 2012

Just a quick question about this. I dont see where the code is calling CREATE EXTENSION hstore; on the ActiveRecord::Base.connection to add support for hstore data types in the Postgres DB. Any insight would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment